[#16169] - [3.8] Restructure version constants
- Fixed in Code Base
- 7 Aug 2017
- Medium
- Build: 3.8-dev
- # 16169
- Diff
- mbabker:version-constants
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR splits up the information in our existing version constants so each value represents one segment of the version string and deprecates the constants which hold combined segments. This also deprecates the BUILD constant as we aren't using it at all.
Testing Instructions
The CMS should function normally and all places working with version data through the functions on our version class should have no change.
Documentation Changes Required
Note the deprecated constants.
TODO
- Update the build script
- Update the version bump script
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_languages Templates (admin) Repository Installation Libraries |
| Labels |
Added:
?
|
||
This isn't going to fix an error where the stack trace points to code in Akeeba Backup. Specifically, the only error it will actually fix is in our packaging script.
Plus, this is a PR targeted for 3.8, not a 3.7 release.
While this mostly fixes an issue with PHP 7.1 and our build script, it also affects outside API use, it'd be nice if folks could please review and test this.
I have tested this item
looks good. Can you update / rebase that to staging?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16169.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-07 14:29:25 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
FWIW the build script does run with this PR applied without warnings, so it is fixing a bug? (granted, only 3 or 4 people might ever run into it)