J3 Issue ?
avatar PhilETaylor
PhilETaylor
19 May 2017

Steps to reproduce the issue

create a custom field with "imagelist"
allow multiple
select 2 images when editing content
view content

Expected result

An IMAGE "LIST"

Actual result

<span class="field-label">imagelist: </span>
<span class="field-value">
<img src="/images/banners/osmbanner1.png" class="myclss £%$^&amp;%*^(&amp;">
<img src="/images/banners/shop-ad-books.jpg" class="myclss £%$^&amp;%*^(&amp;">
</span>

(additional linebreaks my own formatting here for clarity, Joomlas output has varying linebreaks)

System information (as much as possible)

Versions > Joomla 3.7.0

Additional comments

This is NOT a list (in the english sense of the word), this is just dumping out the images one after another.

Can someone define if this is what they would expect?

I would expect a <ul><li><img /></li><li><img /></li></ul> kind of markup for an image "list"

Am I alone? (as always)

avatar PhilETaylor PhilETaylor - open - 19 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 May 2017
avatar PhilETaylor PhilETaylor - edited - 19 May 2017
avatar PhilETaylor PhilETaylor - change - 19 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 19 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 19 May 2017
avatar PhilETaylor PhilETaylor - edited - 19 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 May 2017
Category com_fields
avatar PhilETaylor PhilETaylor - edited - 19 May 2017
avatar PhilETaylor PhilETaylor - change - 19 May 2017
Title
Define "imagelist" requirements
[com_fields] Define "imagelist" requirements
avatar PhilETaylor PhilETaylor - change - 19 May 2017
The description was changed
avatar AlexRed
AlexRed - comment - 19 May 2017

Yes, I confirm, the list images result is not so good.

Is it a good idea also add the ALT tag with the field Label text ?

avatar Bakual
Bakual - comment - 19 May 2017

Selecting the same image twice is probably hard to do given how a HTML select works. The output however could be adjusted. Each field type can use an own layout, eg the imagelist uses this one: https://github.com/joomla/joomla-cms/blob/staging/plugins/fields/imagelist/tmpl/imagelist.php
This is fully overrideable.

Of course it can be changed to a list as well in core if someone wants to do a PR. However without the needed CSS you will get the bullet points before each image which probably isn't what most users want :)

avatar brianteeman
brianteeman - comment - 19 May 2017

I would say that the ability to add alt and title params for each image is essential

avatar PhilETaylor PhilETaylor - comment - 19 May 2017
avatar Quy
Quy - comment - 19 May 2017

For a temporary solution, use the image filename, replace hyphens and dashes with a space, and omit extension.

avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Title
Define "imagelist" requirements
[com_fields] Define "imagelist" requirements
avatar joomla-cms-bot joomla-cms-bot - edited - 19 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Status New Discussion
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 20 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Title
[com_fields] Define "imagelist" requirements
Define "imagelist" requirements
avatar Quy
Quy - comment - 20 May 2017

Minimally, add alt="". I vaguely recall that without alt attribute that the screenreader will read the filename.

avatar brianteeman
brianteeman - comment - 20 May 2017

Minimally, add alt="". I vaguely recall that without alt attribute that the screenreader will read the filename.

That is correct but it is also incorrect to add a blank alt param unless the image is only used for decoration

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Nov 2017
Title
Define "imagelist" requirements
[com_fields] Define "imagelist" requirements
avatar joomla-cms-bot joomla-cms-bot - edited - 7 Nov 2017
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar PhilETaylor PhilETaylor - change - 10 Feb 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-02-10 21:33:48
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 10 Feb 2019

Add a Comment

Login with GitHub to post a comment