? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
19 May 2017

Pull Request for Issue #16121 .

Summary of Changes

Tidy up and bugfix custom field imagelist

Testing Instructions

Create a new Custom Field List of Images for the Content. Create a new article and select an image for the field.
See the article in frontend and see the image path:
src="/Joomla_3.7.1/images**///**image-name.gif"

Apply patch

Expected result

src="/Joomla_3.7.1/images/image-name.gif"

NOTE

Coded without testing

avatar PhilETaylor PhilETaylor - open - 19 May 2017
avatar PhilETaylor PhilETaylor - change - 19 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 19 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 19 May 2017
avatar PhilETaylor PhilETaylor - change - 19 May 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

I have tested this item successfully on 252d94e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

I have tested this item successfully on 252d94e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 May 2017 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 19 May 2017

Please also take a moment to provide feedback on the output of this filed in this issue #16136

avatar AlexRed
AlexRed - comment - 19 May 2017

I have tested this item successfully on cb5e207

Patch ok for me. Thanks.

Is it a good idea also add the ALT tag with the field Label text ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar AlexRed AlexRed - test_item - 19 May 2017 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 19 May 2017

Is it a good idea also add the ALT tag with the field Label text ?

@AlexRed Please add that suggestion here: #16136

avatar Quy
Quy - comment - 19 May 2017

When there is no class, which is preferred with space or no space before /? "/> or " />

avatar PhilETaylor
PhilETaylor - comment - 19 May 2017

I think WITH the space is "more right" ?
Ref: https://www.tutorialspoint.com/xhtml/xhtml_syntax.htm

avatar Quy
Quy - comment - 19 May 2017

I have tested this item successfully on 60b1ac1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar Quy Quy - test_item - 19 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 May 2017

@C-Lodder slashes?

avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Status Ready to Commit Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 May 2017

@AlexRed can you please retest?

avatar AlexRed
AlexRed - comment - 20 May 2017

I have tested this item successfully on 60b1ac1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar AlexRed AlexRed - test_item - 20 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 May 2017

RTC after two successful tests.

avatar PhilETaylor PhilETaylor - comment - 20 May 2017
avatar C-Lodder
C-Lodder - comment - 20 May 2017

They've been all done in Joomla 4. I'm only asking on this so it doesn't need to be addressed when staging is merged into 4.0-dev

avatar dgt41
dgt41 - comment - 20 May 2017

@C-Lodder 3.x is not only HTML5...

avatar PhilETaylor PhilETaylor - comment - 20 May 2017
avatar PhilETaylor PhilETaylor - comment - 20 May 2017
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Labels Added: ?
avatar Quy
Quy - comment - 20 May 2017

I have tested this item successfully on 6aad887


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16135.

avatar Quy Quy - test_item - 20 May 2017 - Tested successfully
avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:20:31
Closed_By rdeutz
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment