? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
19 May 2017

Pull Request for Issue #15621

Summary of Changes

showon does not work for search Tools filters.
Solution: unsetting the page filter when filtering by administrator

After patch one should get

module_page_filter

avatar infograf768 infograf768 - open - 19 May 2017
avatar infograf768 infograf768 - change - 19 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 May 2017
Category Administration com_modules
avatar infograf768
infograf768 - comment - 19 May 2017

Setting to 3.7.2 milestone as this is a B/C break

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

I have tested this item successfully on 3cf21f4

After PR applied search by Page is shown in "Site".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 19 May 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 19 May 2017

I have tested this item successfully on 3cf21f4

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

avatar AlexRed AlexRed - test_item - 19 May 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 19 May 2017

Note: as we do not use language when filtering by admin, after this patch is merged, I will make a specific PR to take off language from the filters and the list. That one could wait 3.7.3 except if I am told otherwise.

avatar infograf768 infograf768 - change - 19 May 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 19 May 2017

RTC. Thanks for testing!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16118.

avatar infograf768
infograf768 - comment - 19 May 2017

@rdeutz
Please merge so that I make a mew PR for language

avatar rdeutz rdeutz - change - 19 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-19 09:08:42
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 19 May 2017
avatar rdeutz rdeutz - merge - 19 May 2017

Add a Comment

Login with GitHub to post a comment