[#16117] - [Calendar] B/C Setting weeknumbers to display per default
- Fixed in Code Base
- 19 May 2017
- Medium
- Build: staging
- # 16117
- Diff
- infograf768:calendar_weeknumbers
User tests: Successful: Unsuccessful:
Pull Request replacing #16104
Summary of Changes
As title says.
Testing Instructions
Patch and make sure all calendar fields display weeknumbers.
Expected result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Libraries |
I have tested this item
Works. Weeknumbers now shown in modules and also in the 3 article settings for start/finish/created.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.
I have tested this item
Tests on Articles and Modules.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16117.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-19 09:35:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Really?
B/C break to have a calendar without the confusing week number?
Joomla will never, ever get a good UI/UX.-
No it is not a b/c break it is just different as it was before
There was a reason for this change: most calendars don't display week numbers (for most users this is confusing and just a cluttered display). One user complains and we ruin the UI/UX for the majority to satisfy the minority?
I give up...
Why on earth would we need to display the week number by default? It's just cluttering up the calendar display and making the click space for the dates smaller. THAT is bad UX
Please can this pr be reverted. As stated this is not a b/c issue. If it
was then we could never change anything ever!
On 19 May 2017 12:49 p.m., "Lodder" notifications@github.com wrote:
Why on earth would we need to display the week number by default? It's
just cluttering up the calendar display and making the click space for the
dates smaller. THAT is bad UX—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16117 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eA6SVNifxw8Jzex9OoKbi9hkwB4ks5r7YHYgaJpZM4NgHzw
.
I have read the original issue and I don't see that there was an agreement that removing the week numbers is the way to go. So in this cases I go with "how it was in the past".
I see arguments for and against enabled by default and I don't know what is the majority and what the minority. So further discussion here will lead to nowhere. There is always the option to open a PR, discuss the topic, come to an agreement and then go from there.
Actually, it's easier for the user to hide the weeknumbers (could be done with CSS) than to add them (needs a JLayout or JS override).
Setting to 3.7.2 as it is a B/C issue.