Feeling Lucky
?
?
[#16077] - Silence PHP Notice on no items tagged
- Fixed in Code Base
- 21 May 2017
- Medium
- Build: staging
- # 16077
- Diff
- PhilETaylor:NoTagsPHPWarning
User tests: Successful: Unsuccessful:
Pull Request for Issue #16067 .
Summary of Changes
Dont run code block when there are no items linked to a tag
Testing Instructions
Install Joomla,
Create a tag
go to front end and load that tags page with url like
http://joomla-cms/index.php?option=com_tags&view=tag&id=3
Expected result
No PHP notices
Actual result
PHP notice
Notice: Trying to get property of non-object in .../components/com_tags/views/tag/view.html.php on line 120
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
franz-wohlkoenig
- comment
- 18 May 2017
I have tested this item
With applied PR got no more Notice in php_error.log
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16077.
franz-wohlkoenig
- comment
- 18 May 2017
@PhilETaylor can you fix failed Build to set RTC?
rdeutz
- comment
- 18 May 2017
can't be fixed within this PR, can be set to RTC
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 18 May 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 12:56:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 21 May 2017
Thanks Phil!
I have tested this item✅ successfully on 6afe198
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16077.