? ? ? Failure

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
17 May 2017

Pull Request for Issue #16000 .

Summary of Changes

Second of 2 PRs to apply #16000. Moves the toolbar apply actions to the table header in com_content->articles.

Testing Instructions

Apply patch and navigate to Content -> Articles. Ensure each item in the dropdown functions correctly.

thead-actions

Documentation Changes Required

Yes

avatar ciar4n ciar4n - open - 17 May 2017
avatar ciar4n ciar4n - change - 17 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2017
Category Administration com_content Language & Strings Templates (admin) Libraries
avatar brianteeman
brianteeman - comment - 17 May 2017

personally i wouldnt move batch to this group but thats something for a ux team review

avatar ciar4n
ciar4n - comment - 17 May 2017

I can move batch back to the toolbar until such time UX can review the best location?

avatar brianteeman
brianteeman - comment - 17 May 2017

Yes please

On 17 May 2017 3:03 p.m., "Ciaran Walsh" notifications@github.com wrote:

I can move batch back to the toolbar until such time UX can review the
best location?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#16076 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8d0TMUyz4NObRYhprlA4iBXkwEf4ks5r6v4ZgaJpZM4NdynO
.

avatar ciar4n ciar4n - change - 17 May 2017
Labels Added: ? ?
avatar ciar4n
ciar4n - comment - 17 May 2017

Done

avatar brianteeman
brianteeman - comment - 26 May 2017

it works but i have some odd styling issues
screenshotr11-09-58
screenshotr11-10-04

avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2017
Category Administration com_content Language & Strings Templates (admin) Libraries Administration com_content Language & Strings Templates (admin) Libraries Front End Templates (site)
avatar ciar4n
ciar4n - comment - 29 May 2017

Thank you @brianteeman

Webkit appearance fix committed, resolving this issue.

avatar brianteeman
brianteeman - comment - 29 May 2017

I have tested this item successfully on 64cf207

Thanks @ciar4n


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16076.

avatar brianteeman brianteeman - test_item - 29 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 May 2017

Click on "Apply Patch" got:

Error
The file marked for modification does not exist: administrator/components/com_content/views/articles/tmpl/default.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16076.

avatar C-Lodder
C-Lodder - comment - 31 May 2017

Not sure about this. Having looked at it again now, I don't think a dropdown in the table header would be the best place. The toolbar is where list actions have always resided in Joomla, so I think it would be best to keep them there, and group them.

Submitting that sort of PR would of course get grilled by some just for the sake of it.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 May 2017

Test on fresh installed nightly Build full Package:
bildschirmfoto 2017-05-31 um 12 33 51

avatar C-Lodder
C-Lodder - comment - 31 May 2017

@franz-wohlkoenig - that was to do with another PR that was submitted yesterday. Just needs to fix conflicts.

avatar ciar4n
ciar4n - comment - 4 Jun 2017

@coolcat-creations Conflicts fixed

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jun 2017
Category Administration com_content Language & Strings Templates (admin) Libraries Front End Templates (site) Administration com_content Language & Strings Templates (admin) Libraries
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman
brianteeman - comment - 8 Apr 2018

What is the status on this or is it redundant with the new admin ui
?

avatar ciar4n
ciar4n - comment - 8 Apr 2018

Personally I still consider this a viable UI solution. It is not part of the new design.

avatar laoneo
laoneo - comment - 9 Apr 2018

Can you fix the conflicts here and make the dog happy?

avatar laoneo
laoneo - comment - 10 Apr 2018

Can you still unpublish multiple articles with this pr?

avatar coolcat-creations
coolcat-creations - comment - 10 Apr 2018
avatar laoneo
laoneo - comment - 10 Apr 2018

I mean multiple items.

avatar coolcat-creations
coolcat-creations - comment - 10 Apr 2018

Yes thats the indent of the Action Button.

avatar laoneo
laoneo - comment - 10 Apr 2018

Now I got it right, the actions menu in the table header is for all articles and the three dots are per article. Thanks for clarification.

avatar coolcat-creations
coolcat-creations - comment - 10 Apr 2018

I applied the current designapproach which makes it probably more obvious :) The concept in the header is not how it will be...

avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2018
Category Administration com_content Language & Strings Templates (admin) Libraries Administration com_content Language & Strings Templates (admin) Libraries External Library Composer Change Front End Templates (site)
avatar ciar4n ciar4n - change - 10 Apr 2018
Labels Added: ?
avatar ciar4n
ciar4n - comment - 10 Apr 2018

Conflicts and hound errors fixed

avatar laoneo
laoneo - comment - 10 Apr 2018

Had a look on it now. I do miss here the connection to the checkboxes, something feels for me not clear, especially when a first time user opens that list. But eager to hear other opinions.

avatar ciar4n
ciar4n - comment - 10 Apr 2018

Had a look on it now. I do miss here the connection to the checkboxes, something feels for me not clear, especially when a first time user opens that list. But eager to hear other opinions.

We could hide the 'actions' button until an item has been selected. Animating the button in on selection I believe would make more of a visible connection between the selected items and the button. It is hard for me to look at this with 'new' eyes to completely agree with you.

Regardless maybe best putting this on hold until the template has changed. It is only within the new design that the point can be properly tested. It would make for a good userbob test.

avatar laoneo
laoneo - comment - 11 Apr 2018

Agree. As one more option. Here is the Google way
image

avatar coolcat-creations
coolcat-creations - comment - 11 Apr 2018

If you click through the draft, the button was designed "inactive" until the user selects something. This is due to usability. Just start from the beginning and click yourself through to the article overview: https://projects.invisionapp.com/share/8SES9JLZB#/screens/266861164_Desktop_-_Login

avatar brianteeman
brianteeman - comment - 29 Mar 2019

This should be closed as the concept has been applied in another pr. My 2c

avatar ciar4n
ciar4n - comment - 29 Mar 2019

Closed as suggested.

avatar ciar4n ciar4n - change - 29 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-29 18:40:54
Closed_By ciar4n
avatar ciar4n ciar4n - close - 29 Mar 2019

Add a Comment

Login with GitHub to post a comment