[#16048] - Fix shortDays array order
- Fixed in Code Base
- 16 May 2017
- Medium
- Build: staging
- # 16048
- Diff
- machadoug:patch-1
User tests: Successful: Unsuccessful:
shortDays array was displaying Monday (Seg) as the first day of the week, however the calendar displays Sunday as the first day, so the shortDays must be changed accordingly.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Language & Strings |
@machadoug @horus68 @Bakual you can rearrange the array, as it's done here, or change the weekend value in the language xml file (I think is better to keep the array order reflecting the original EN)
I'm referring to this line: https://github.com/joomla/joomla-cms/blob/staging/language/en-GB/en-GB.xml#L19
Also there is a firstDay: https://github.com/joomla/joomla-cms/blob/staging/language/en-GB/en-GB.xml#L18
So tweaking these values we can have the same result without rearranging the days array...
@dgt41, actually the value of the shortDays array is actually wrong in pt.js file. It should match the days array, regardless of the configuration in the xml file.
In other words, the days array position should match the shortDays array position. The changes suggested set Sunday as the first position in both cases.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-16 19:18:40 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
?
|
||
Those files are provied by the language teams.?
Pinging @helvecio and @horus68 so they can approve this change and take the changes to his own file. Not sure which one provided the file