Feeling Lucky
?
?
[#16002] - [4.0] replace own joomla's highlighter with mark.js
- Closed
- 24 May 2017
- Medium
- Build: 4.0-dev
- # 16002
- Diff
- dgt41:#####4.0-highlighter
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This is a POC/RFC
Summary of Changes
- Remove highlighter.(min.)js
- Remove
behavior.highlighter - Introduce
behavior.highlight
Testing Instructions
Not yet testable
Expected result
Same highlighting as before
Actual result
Documentation Changes Required
YUP
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder Repository Libraries JavaScript Plugins Unit Tests |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 14 May 2017
I'm happy with moving to something Not In House but I'd rather keep the PHP API b/c from 3.x and deprecate the old API for 5 if we can
brianteeman
- comment
- 14 May 2017
What is the problem this is solving? Does it provide anything more than we have right now?
dgt41
- comment
- 14 May 2017
What is the problem this is solving? Does it provide anything more than we have right now?
Two objectives:
- vanilla javascript (no dependencies, also this script is future proof, e.g. ES6)
- less code to support in-house...
dgt41
- comment
- 24 May 2017
I will redo the PHP part so we can keep B/C here
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 21:25:11 |
| Closed_By | ⇒ | dgt41 |
OK I'm not against us moving to this new library. But let's have a think about working out a method of making the old JHtml method signature work with the new library, if possible.