[#15948] - Associations Race Condition Fix
- Fixed in Code Base
- 11 May 2017
- Medium
- Build: staging
- # 15948
- Diff
- PhilETaylor:AssLoading
User tests: Successful: Unsuccessful:
Pull Request for Issue #15945 .
@infograf768
Summary of Changes
One simple and quick way to
- Prove it was a race condition
- Badly use JS to overcome race condition by loading second iframe once the first has loaded (and more importantly closed the session)
Testing Instructions
As per #15945
Create a basic multilingual site (2 languages are enough).
Logout.
Quit browser (tested here with FF and Safari)
Relaunch browser, log in the admin and display Multingual associations.
Choose an article and language (here default Article (en-gb)
Click on the Associations label for French.
Expected result
Both panes should load with no "You are not auth....." message shown, ever, when testing.
Note
There is probably a better (and yes, non jQuery way) to do this, but this works and its as dirty as the rest of the jQuery code knocking about in this place.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations JavaScript |
| Labels |
Added:
?
|
||
I have tested this item
Patch ok for me.
Test on Firefox
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15948.
@infograf768 Done.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15948.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks!
One more that can go in. :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15948.
I want to get the Tab State JS into Joomla 3.7.1 as well, any idea why most RTC PR are set for 3.7.2 and not 3.7.1 ?
apparently the aim is for 3.7.1 to be a minimal release just addressing bugs introduced in 3.7.0 (so i heard)
Well thats crazy... just means users have 2 updates to do, and have to wait longer for fixes... The important Joomla 3.7.0 bugs have not even been fixed yet, while there are a LOT of bug fixes RTC with 3.7.2 milestone attached now... /facepalm
Well thats crazy
No it is not, we need to stabilise the release and not introduce new bugs because of the small timeframe we have for testing. I have also set almost anything what needs a language file change to 3.7.2 because we are not going to a language freeze and translation teams don't have the time to make new language files.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-11 10:02:31 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
@PhilETaylor
Works GREAT! Can you just indent with tab in the js and I can test it OK