? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 May 2017

This is the latest release of tinmyce BUT from the changelog - pay special note to the first item in bold

Dropped support for IE 8-10 due to market share and lack of support from Microsoft. See tinymce docs for details.
ADDED an inline boundary caret position feature that makes it easier to type at the beginning/end of links/code elements.
ADDED a help plugin that adds a button and a dialog showing the editor shortcuts and loaded plugins.
ADDED an inline_boundaries option that allows you to disable the inline boundary feature if it's not desired.
ADDED a new ScrollIntoView event that allows you to override the default scroll to element behavior.
ADDED role and aria- attributes as valid elements in the default valid elements config.
ADDED new internal flag for PastePreProcess/PastePostProcess this is useful to know if the paste was coming from an external source.
ADDED new ignore function to UndoManager this works similar to transact except that it doesn't add an undo level by default.
FIXED so that urls gets retained for images when being edited. This url is then passed on to the upload handler.
FIXED so that the editors would be initialized on readyState interactive instead of complete.
FIXED so that the init event of the editor gets fired once all contentCSS files have been properly loaded.
FIXED so that width/height of the editor gets taken from the textarea element if it's explicitly specified in styles.
FIXED so that keep_styles set to false no longer clones class/style from the previous paragraph on enter.
FIXED so that the default line-height is 1.2em to avoid zwnbsp characters from producing text rendering glitches on Windows.
FIXED so that loading errors of content css gets presented by a notification message.
FIXED so figure image elements can be linked when selected this wraps the figure image in a anchor element.
FIXED bug where it wasn't possible to copy/paste rows with colspans by using the table copy/paste feature.
FIXED bug where the protect setting wasn't properly applied to header/footer parts when using the fullpage plugin.
FIXED bug where custom formats that specified upper case element names where not applied correctly.
FIXED bug where some screen readers weren't reading buttons due to an aria specific fix for IE 8.
FIXED bug where cut wasn't working correctly on iOS due to it's clipboard API not working correctly.
FIXED bug where Edge would paste div elements instead of paragraphs when pasting plain text.
FIXED bug where the textpattern plugin wasn't dealing with trailing punctuations correctly.
FIXED bug where image editing would some times change the image format from jpg to png.
FIXED bug where some UI elements could be inserted into the toolbar even if they where not registered.
FIXED bug where it was possible to click the TD instead of the character in the character map and that caused an exception.
FIXED bug where the font size/font family dropdowns would sometimes show an incorrect value due to css not being loaded in time.
FIXED bug with the media plugin inserting undefined instead of retaining size when media_dimensions was set to false.
FIXED bug with deleting images when forced_root_blocks where set to false.
FIXED bug where input focus wasn't properly handled on nested content editable elements.
FIXED bug where Chrome/Firefox would throw an exception when selecting images due to recent change of setBaseAndExtent support.
FIXED bug where malformed blobs would throw exceptions now they are simply ignored.
FIXED bug where backspace/delete wouldn't work properly in some cases where all contents was selected in WebKit.
FIXED bug with Angular producing errors since it was expecting events objects to be patched with their custom properties.
FIXED bug where the formatter would apply formatting to spellchecker errors now all bogus elements are excluded.
FIXED bug with backspace/delete inside table caption elements wouldn't behave properly on IE 11.
FIXED bug where typing after a contenteditable false inline element could move the caret to the end of that element.
FIXED bug where backspace before/after contenteditable false blocks wouldn't properly remove the right element.
FIXED bug where backspace before/after contenteditable false inline elements wouldn't properly empty the current block element.
FIXED bug where vertical caret navigation with a custom line-height would sometimes match incorrect positions.
FIXED bug with paste on Edge where character encoding wasn't handled properly due to a browser bug.
FIXED bug with paste on Edge where extra fragment data was inserted into the contents when pasting.
FIXED bug with pasting contents when having a whole block element selected on WebKit could cause WebKit spans to appear.
FIXED bug where the visualchars plugin wasn't working correctly showing invisible nbsp characters.
FIXED bug where browsers would hang if you tried to load some malformed html contents.
FIXED bug where the init call promise wouldn't resolve if the specified selector didn't find any matching elements.
FIXED bug where the Schema isValidChild function was case sensitive.

avatar brianteeman brianteeman - open - 7 May 2017
avatar brianteeman brianteeman - change - 7 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Category External Library JavaScript
avatar mbabker
mbabker - comment - 7 May 2017

Unless we're dropping IE8 support in 3.x, I don't think we can make this jump.

avatar brianteeman
brianteeman - comment - 7 May 2017

I agree BUT I cant find the docs they refer to in order to understnd exactly what they mean by the statement

avatar mbabker
mbabker - comment - 7 May 2017

We're probably going to have to comb their commit logs to find the references. Everything I've read so far just says "we dropped support" with no indication if anything actually changed.

avatar brianteeman
brianteeman - comment - 7 May 2017

Will be interesting to see what WP does.

avatar mbabker
mbabker - comment - 7 May 2017
avatar dgt41
dgt41 - comment - 7 May 2017

It's going to be pretty broken in IE8, unless we polyfill things that are not available in IE8 e.g. addEventListener: tinymce/tinymce@c8041cb

Probably doable, but someone needs to go through the required functions that are not available in IE8, we do have the polyfills already in 3.7

avatar dgt41
dgt41 - comment - 7 May 2017

@brianteeman @mbabker this WP subproject is amazing: https://github.com/WordPress/gutenberg
In essence the are rebuilding tinymce to fit their needs! Awesome!

avatar mbabker
mbabker - comment - 7 May 2017

I get around the open source circles, I've seen it a time or three already ?

avatar brianteeman
brianteeman - comment - 7 May 2017

so far wp are on the saame version as us

avatar dgt41
dgt41 - comment - 7 May 2017

One easy way to have 4.6 in 3.8 is:
add in your template top <script src="https://cdn.polyfill.io/v2/polyfill.min.js"></script>
then edit an article in IE8 and observe which polyfills are used.
Make a conditional use of these polyfills before the tinymce.js
Problem solved (probably)

avatar mbabker
mbabker - comment - 7 May 2017

I'll leave it to you JavaScript smarties to sort out. Tiny's blog indicated 4.5 would be on long term support so presumably we'd be OK on the "safe" route of using it for the remainder of 3.x and sticking on a stable path. There's also time to sort things out so no rush yet.

avatar dgt41
dgt41 - comment - 7 May 2017

@brianteeman @mbabker if it's only the events that are missing in IE8 then this will work as is: https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/tinymce/tinymce.php#L52
We are already polyfilling the events for IE8

avatar brianteeman
brianteeman - comment - 7 May 2017

Ok. I will do another pr to get us to the last version in 4.5

avatar brianteeman
brianteeman - comment - 7 May 2017

Ah I had already done that - its just not been merged #15701

avatar brianteeman brianteeman - change - 7 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-07 19:40:54
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 7 May 2017
avatar mbabker
mbabker - comment - 7 May 2017

Let's keep this open for now. At least we can evaluate and determine if it's practical for us to upgrade.

avatar mbabker mbabker - change - 7 May 2017
Status Closed New
Closed_Date 2017-05-07 19:40:54
Closed_By brianteeman
avatar mbabker mbabker - change - 7 May 2017
Status New Pending
avatar mbabker mbabker - reopen - 7 May 2017
avatar brianteeman
brianteeman - comment - 7 May 2017

Ok fair enough but reading the blog this version won't even open in ie8-10

avatar mbabker
mbabker - comment - 7 May 2017

I saw that too. Honestly the worst thing that happens is someone takes 2 minutes, tests this (even with us having polyfilled stuff), and determines it can't work.

avatar ot2sen
ot2sen - comment - 7 May 2017

Makes sense when Microsoft ended support for ie8-10 14mth ago, then it is not TinyMCE nor our task to keep support for EOL tools alive. https://www.microsoft.com/en-us/windowsforbusiness/end-of-ie-support

GitHub go a step further which you will see when visiting this current page in ie11
07-05-2017_github_drop_all_ie_support

avatar dgt41
dgt41 - comment - 7 May 2017

Yeah and we have people in the community that respond like this:
screen shot 2017-05-07 at 23 08 51

And expect Joomla 4 to support IE8 ?

avatar brianteeman
brianteeman - comment - 7 May 2017

well there is definitely a different level of expectation between the
software installed on a developers computer and that on a consumer

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On 7 May 2017 at 21:10, Dimitri Grammatikogianni notifications@github.com
wrote:

Yeah and we have people in the community that respond like this:
[image: screen shot 2017-05-07 at 23 08 51]
https://cloud.githubusercontent.com/assets/3889375/25784695/36f83712-337a-11e7-836d-294554b7f61c.png

And expect Joomla 4 to support IE8 ?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#15879 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UXQwz67Gz0msUlHXv2RDb-Bx40Wks5r3iVGgaJpZM4NTQrZ
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 7 May 2017

@brianteeman there is no logic on supporting software that even the company that created it doesn't support anymore

avatar brianteeman
brianteeman - comment - 7 May 2017

Dont believe that they dont support it. They might not support it to home consumers but they do offer out of support contracts to large corporates and governments

avatar C-Lodder
C-Lodder - comment - 7 May 2017

As J3 needs to support IE8, it would be pretty pointless upgrading TinyMCE to 4.6 and adding a polyfill.

There are simply way too may test cases.

avatar brianteeman
brianteeman - comment - 23 May 2017

Closing this for the compatibility versions stated above (plus we are know at 3.6.1 anyway)

avatar brianteeman brianteeman - change - 23 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-23 08:18:59
Closed_By brianteeman
avatar brianteeman brianteeman - close - 23 May 2017

Add a Comment

Login with GitHub to post a comment