[#15877] - [4.0] remove slash
- Closed
- 24 May 2017
- Medium
- Build: 4.0-dev
- # 15877
- Diff
- brianteeman:hr_not_hr_slash
User tests: Successful: Unsuccessful:
continue the removal of closing slashes for tags that do not require this in html5
@dgt41 I spotted several changes that would need to be made in the JS too but I have not touched them
admin-article-pagebreak.js
com_finder/js etc
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content Language & Strings Templates (admin) Front End Plugins Templates (site) Unit Tests |
i am not set up for running grunt etc right now. will take me a few days till i have the time to do that
| Labels |
Added:
?
?
?
|
||
| Category | Administration com_content Language & Strings Templates (admin) Front End Plugins Templates (site) Unit Tests | ⇒ | Administration com_content Language & Strings Templates (admin) Front End JavaScript Plugins Templates (site) Unit Tests |
looks fine, you have one conflict tho
Conflicts resolved
grrh merge conflicts
Showing we have conflicts here..
That's fine. Sorry you didn't comment after you fixed the typo so I didn't get a notification
Closed. I really cant be bothered to have anything to do with js in j4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 11:52:18 |
| Closed_By | ⇒ | brianteeman |
Brian, keep it open and I'll push a PR to your repo after lunch with the fixes
no its deleted now
This is a convention so:
By the way I didn't came up with this, but it really makes sense...