? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 May 2017

Fix for TinyMCE plugin configuration.
In some reason I cannot find tinymce-builder.js in 4.0-dev branch, so I copied the file from staging manualy.

Testing Instructions

Check TinyMCE plugin configuration

Expected result

the styling is broken, you cannot edit the toolbar

Actual result

the styling looks good, you can edit the toolbar

avatar Fedik Fedik - open - 7 May 2017
avatar Fedik Fedik - change - 7 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Category Layout JavaScript External Library
avatar dgt41
dgt41 - comment - 7 May 2017

I had a PR that for this: #15371 but I guess it's too big

avatar Fedik
Fedik - comment - 7 May 2017

yes, looks huge ?

avatar dgt41
dgt41 - comment - 7 May 2017

it's ok, as long as it's fixed :)
Couple things here:
You are using sortable and jQuery-ui, but we try to go away from that in core so we use dragulla instead. Do you feel like dropping jquery and jQuery-ui for the builder?
For chosen we are planing to use choices but we're waiting for a feature to be merged...

avatar Fedik
Fedik - comment - 7 May 2017

Do you feel like dropping jquery and jQuery-ui for the builder?

Currently I just tried to make it work again ?

The thing, that jQuery-ui is a core of whole builder, so it require a lot rewriting.
Maybe sometime later.
Also will be need some time to check how the dragula.js works with multiple instances.

For chosen we are planing

I am fine with native <select> ?

avatar dgt41
dgt41 - comment - 7 May 2017

I am fine with native So do I, but there are few places (tags, modules, categories on the fly) that we need a better ui or some search functionality, so there is a legitimate case using javascript driven element there. The best solution will be to find a custom element for that but I haven't see anything that fits our use case so far

avatar wilsonge wilsonge - close - 8 May 2017
avatar wilsonge wilsonge - merge - 8 May 2017
avatar wilsonge wilsonge - change - 8 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-08 09:21:00
Closed_By wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment