? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
7 May 2017

Pull Request for Issue # .

Summary of Changes

This simple PR convert com_checkin component to namespace MVC for Joomla 4.

Testing Instructions

  1. Install latest Joomla 4.0-dev with sample data, then apply patch (or better install my branch https://github.com/joomdonation/joomla-cms/archive/namespace_com_checkin.zip )

  2. Access to Content -> Articles, click on an article to edit, without saving (so that the article will be checked in)

  3. Access to System -> Global Checkin, try to checkin the table, make sure it is working as expected.

avatar joomdonation joomdonation - open - 7 May 2017
avatar joomdonation joomdonation - change - 7 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Category Administration com_checkin
avatar joomdonation
joomdonation - comment - 7 May 2017

83 | ERROR | Constructor and destructor comments must not have a @return tag

The codestyle check is wrong in this case. The method name is checkin (same with class name), so it thinks that the method is constructor but it is not. Not sure what to do in this case.

avatar joomdonation joomdonation - change - 7 May 2017
Labels Added: ?
avatar joomdonation joomdonation - change - 7 May 2017
Title
Namespace com_checkin
[4.0] Namespace com_checkin
avatar joomdonation joomdonation - edited - 7 May 2017
avatar wilsonge wilsonge - change - 8 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-08 09:18:48
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 May 2017
avatar wilsonge wilsonge - merge - 8 May 2017

Add a Comment

Login with GitHub to post a comment