?
avatar mbabker
mbabker
7 May 2017

Got other stuff going on so no time to do PRs myself, but...

  • Bad links to github.com/joomla (looks like the protocol is missing in the URL as Screaming Frog gives me a link of http://jcms/github.com/joomla when I crawl my local install)
  • A welcome.html link
  • archived-articles/2011 gives a 404 (but archived-articles is good)
avatar mbabker mbabker - open - 7 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 May 2017
Category Installation Templates (site) UI/UX
avatar brianteeman
brianteeman - comment - 7 May 2017

See #15868 for the first two - I couldnt replicate/find the last one

avatar mbabker
mbabker - comment - 7 May 2017

This might not something you can sort out. I did another crawl to try and get the source creating that link and found this...

screen shot 2017-05-07 at 9 51 14 am

avatar brianteeman
brianteeman - comment - 7 May 2017

yeah i tested the archive sample and it seemed ok

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 May 2017
Status New Discussion
avatar Quy
Quy - comment - 15 May 2017

Found the link:
<base href="http://localhost/joomla-cms/index.php/archived-articles/2011" />

on this page:
http://localhost/joomla-cms/index.php/archived-articles/2011?view=archive&month=1

avatar brianteeman
brianteeman - comment - 15 May 2017

But can you find it in the dB to fix?

avatar Quy
Quy - comment - 15 May 2017

I don't think so. I assume the base tag is dynamically being generated.

avatar Quy
Quy - comment - 15 May 2017

It is missing the query portion ?view=archive&month=1 that is causing the issue.

avatar mbabker
mbabker - comment - 15 May 2017

So to me then we've got a routing bug somewhere as a URL should be valid
when SEF is enabled with no query strings attached.

On Mon, May 15, 2017 at 5:53 PM Quy notifications@github.com wrote:

It is missing the query portion ?view=archive&month=1 that is causing the
issue.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#15863 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobeH33DKVDwgFelqnid_8eC8FbJeks5r6Nd4gaJpZM4NS-KN
.

--

  • Michael Please pardon any errors, this message was sent from my iPhone.
avatar Quy
Quy - comment - 16 May 2017

This link is generated:
http://localhost/joomla-cms/index.php/archived-articles/2011?view=archive&month=1

when it should be:
http://localhost/joomla-cms/index.php/archived-articles?view=archive&month=1&year=2011

I will try to track down where this URL is generated.

avatar Quy
Quy - comment - 23 May 2017

In \components\com_content\helpers\legacyrouter.php, the following was changed from:

		if ($view == 'archive')
		{
			if (!$menuItemGiven)
			{
				$segments[] = $view;
				unset($query['view']);
			}

			if (isset($query['year']))
			{
				if ($menuItemGiven)
				{
					$segments[] = $query['year'];
					unset($query['year']);
				}
			}

			if (isset($query['year']) && isset($query['month']))
			{
				if ($menuItemGiven)
				{
					$segments[] = $query['month'];
					unset($query['month']);
				}
			}
		}

to make it work:

		if ($view == 'archive')
		{
			if (!$menuItemGiven)
			{
				$segments[] = $view;
			}

			unset($query['view']);
		}

I don't know if this is the right solution. If no, then I am out of ideas.

avatar brianteeman
brianteeman - comment - 18 Aug 2017

@Quy could you make a PR for this

avatar Quy
Quy - comment - 18 Aug 2017

@brianteeman I am out until Monday when I can do it then.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Dec 2017

gently Reminder @Quy

avatar Quy
Quy - comment - 11 Dec 2017

Related to #13757. Please close this one. Thanks.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Dec 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-12-11 19:23:03
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 11 Dec 2017
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2017
Closed_Date 2017-12-11 19:23:03 2017-12-11 19:23:04
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 11 Dec 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Dec 2017

closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15863.

Add a Comment

Login with GitHub to post a comment