? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
6 May 2017

Summary of Changes

The installer needs a facelift to match the look and feel of Joomla 4.
This PR deals only with the error page if the PHP version is not supported.

  • Page now is proper HTML
  • Page now supports translation
  • Page loads in the default browser language (if there is a valid translation)
  • Page now supports help links (the relative pages need to be created in joomla.org)
  • There is an automation task in Grunt (installation) that converts the required strings to a javascript object.

@MATsxm @Bakual @infograf768 please review the translation strings and the links for help etc

All the CSS and markup is done by @ciar4n

Testing Instructions

Download https://github.com/dgt41/joomla-cms/archive/4.0-php-error-page.zip
and try to install

Preview

Joomla 3

unknown

Joomla 4

screen shot 2017-05-06 at 16 42 22

Documentation Changes Required

avatar dgt41 dgt41 - open - 6 May 2017
avatar dgt41 dgt41 - change - 6 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2017
Category JavaScript Repository Installation Language & Strings
avatar dgt41 dgt41 - change - 6 May 2017
The description was changed
avatar dgt41 dgt41 - edited - 6 May 2017
avatar dgt41 dgt41 - change - 6 May 2017
Labels Added: ? ?
avatar dgt41
dgt41 - comment - 6 May 2017

@ciar4n can you beatify the select element?

avatar dgt41 dgt41 - change - 6 May 2017
The description was changed
avatar dgt41 dgt41 - edited - 6 May 2017
04f9aa0 6 May 2017 avatar dgt41 meta
avatar wilsonge wilsonge - close - 6 May 2017
avatar wilsonge wilsonge - merge - 6 May 2017
avatar wilsonge wilsonge - change - 6 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-06 21:16:20
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment