? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
6 May 2017

Pull Request for Issue #15842

Summary of Changes

Fix Calendar field for subform field, again.

Testing Instructions

Make sure that calendar field work in the subform
Example xml, can place in "Custom HTML" module xml (somwhere in params fieldset):

<field name="items" type="subform"  multiple="true"  label="Subform Field" >
  <form>
    <field name="something"  type="calendar" label="Calendar" />
  </form>
</field>

Documentation Changes Required

none

avatar Fedik Fedik - open - 6 May 2017
avatar Fedik Fedik - change - 6 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2017
Category JavaScript
avatar dgt41
dgt41 - comment - 6 May 2017

I have tested this item successfully on b817555


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15848.

avatar dgt41 dgt41 - test_item - 6 May 2017 - Tested successfully
avatar laoneo
laoneo - comment - 8 May 2017

I have tested this item successfully on b817555


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15848.

avatar laoneo laoneo - test_item - 8 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 May 2017

RTC after two successful tests.

avatar rdeutz
rdeutz - comment - 9 May 2017

@laoneo @dgt41 @Fedik can you have a look at this #15842 (comment) comment, seems not fixed 100%

avatar rdeutz rdeutz - change - 9 May 2017
Status Ready to Commit Needs Review
avatar dgt41
dgt41 - comment - 9 May 2017

@rdeutz this PR should fix it

avatar wilsonge wilsonge - change - 12 May 2017
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-12 11:22:23
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 May 2017
avatar wilsonge wilsonge - merge - 12 May 2017
avatar wilsonge
wilsonge - comment - 12 May 2017

Looks like it solved the issue Robert mentioned (and the test was just bad). As this was RTC previously and all that's happened since is a rebase I've merged this :)

Add a Comment

Login with GitHub to post a comment