? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
5 May 2017

Summary of Changes

Don't generate warnings, with full path disclosure
Need to be logged in as admin so not a security issue really.

Testing Instructions

Go to http://127.0.0.1:8000/administrator/index.php?option=com_contenthistory&view=preview&layout=preview&tmpl=component
or
http://127.0.0.1:8000/administrator/index.php?option=com_contenthistory&view=compare&layout=compare

See warnings

Expected result

No warnings

Actual result

 Warning: Invalid argument supplied for foreach() in /Users/phil/Sites/joomla-cms/administrator/components/com_contenthistory/helpers/contenthistory.php on line 32
 
 Warning: Invalid argument supplied for foreach() in /Users/phil/Sites/joomla-cms/administrator/components/com_contenthistory/helpers/contenthistory.php on line 295
 **The most recent request was denied because it contained an invalid security token. Please refresh the page and try again.**

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 5 May 2017
avatar PhilETaylor PhilETaylor - change - 5 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2017
Category Administration com_content com_contenthistory
avatar PhilETaylor PhilETaylor - change - 5 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 5 May 2017
avatar PhilETaylor PhilETaylor - change - 5 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 5 May 2017
avatar Quy
Quy - comment - 5 May 2017

I have tested this item successfully on 4cb6808


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15841.

avatar Quy Quy - test_item - 5 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 May 2017

I have tested this item successfully on 4cb6808

I have replicated the issue and can confirm this PR fixes it


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15841.

avatar brianteeman brianteeman - test_item - 5 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 6 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 May 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 7 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-07 10:58:25
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 7 May 2017
avatar wilsonge wilsonge - merge - 7 May 2017
avatar wilsonge
wilsonge - comment - 7 May 2017

THanks!

Add a Comment

Login with GitHub to post a comment