? ? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
5 May 2017

Translate "Asset Id" when viewing version of user notes category (Like anyone even uses this feature! :-( )

Users > User Note Categories -> Edit -> Versions -> Preview

Pull Request for Issue Closes #15166 .

Summary of Changes

Language string missing - now not :)

avatar PhilETaylor PhilETaylor - open - 5 May 2017
avatar PhilETaylor PhilETaylor - change - 5 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2017
Category Administration com_categories Language & Strings
avatar PhilETaylor PhilETaylor - change - 5 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 5 May 2017
avatar brianteeman
brianteeman - comment - 5 May 2017

i wonder why we are even displaying the asset_id at all as we dont in any other version history eg categories

avatar mbabker
mbabker - comment - 5 May 2017

My first thought too. Seems like a system detail that honestly I don't think needs tracked in history unless the ACL state is too and that ID definitely doesn't need to be shown to the user (aside from the debug reports, where are we actually showing asset IDs in the admin UI?).

avatar brianteeman
brianteeman - comment - 5 May 2017

My vote would be to remove it from this view as we dont show it anywhere else

avatar brianteeman brianteeman - change - 19 May 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 19 May 2017

I have tested this item successfully on b270873


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15840.

avatar brianteeman brianteeman - test_item - 19 May 2017 - Tested successfully
avatar Quy
Quy - comment - 19 May 2017

I have tested this item successfully on b270873


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15840.

avatar Quy Quy - test_item - 19 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:34:28
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment