[#15757] - Notice: Undefined index: cache_path in /administrator/components/com_config/model/application.php on line 289
- Fixed in Code Base
- 4 May 2017
- Medium
- Build: staging
- Easy Test
- # 15757
- Diff
- infograf768:notice_cache_path
User tests: Successful: Unsuccessful:
As title says:
Test instructions
Create a Site Settings menu item, display it in frontend.
Log as superadmin and save the site settings.
The Notice above will display in the PHP logs.
Patch. No more Notice.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15757.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15757.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
We shouldn't have client specific handling in our save global configuration routine. Also, this now results in the $path variable being undefined when you get into the next check which would emit a PHP warning except for the fact we're using error suppression.
Would you prefer a simple:
if (isset($data['cache_path']))
{
$path = $data['cache_path'];
}
elseif (!empty($prev['cache_path']))
{
$path = $prev['cache_path'];
}
else
{
$path = JPATH_SITE . '/cache';
}
isset would be better and more consistent with the existing checks.
| Labels |
Added:
?
|
||
Done.
@AlexRed @franz-wohlkoenig
Please test again
| Status | Ready to Commit | ⇒ | Pending |
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15757.
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15757.
| Status | Pending | ⇒ | Ready to Commit |
RTC
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-04 07:25:51 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 46be6bb
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15757.