? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
3 May 2017

Pull Request for Issue #15304.

Summary of Changes

Consider the show label setting in the contact field override.

A question remains. Should the whole <dt></dt> being hidden or just the span which shows the label?

Testing Instructions

  • Create a contact custom field.
  • Set the show label option to false.
  • Edit a contact and fill in a value for the new field.
  • Save the contact.
  • Create a contact menu item.
  • Open the contact on the front.

Expected result

The label is not shown for the custom field.

Actual result

The label is shown for the custom field.

avatar laoneo laoneo - open - 3 May 2017
avatar laoneo laoneo - change - 3 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2017
Category Front End com_contact com_fields
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 May 2017

I have tested this item successfully on 5163aef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15756.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 May 2017
Easy No Yes
avatar ciar4n
ciar4n - comment - 10 May 2017

I have tested this item successfully on 5163aef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15756.

avatar ciar4n ciar4n - test_item - 10 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 May 2017

RTC after two successful tests.

avatar laoneo
laoneo - comment - 10 May 2017

Thanks!

avatar rdeutz rdeutz - close - 10 May 2017
avatar rdeutz rdeutz - merge - 10 May 2017
avatar rdeutz rdeutz - change - 10 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-10 15:03:27
Closed_By rdeutz
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment