[#15578] - New button max width breaks b/c with 3pd
- Closed
- 3 May 2017
- Medium
- Build: staging
- # 15578
Steps to reproduce the issue
Install Admin Tools Professional
Go to HTAccess Maker view
or
As a developer, create a toolbar button with a lot of text in
Expected result
Buttons can be any width the developer wants
Actual result
Long buttons wrap
System information (as much as possible)
Additional comments
b/c break introduced in Joomla 3.7.0
@nikosdion
| Labels |
Added:
?
|
||
| Category | ⇒ | com_plugins Layout |
| Status | New | ⇒ | Discussion |
I don't think I'd call this a B/C break
Shhh someone might hear you ;-)
The issue here as I see it is the max width was not set on purpose. It is only been applied to #toolbar .btn-success which is a bit random (myself to blame).
If a max-width is to be applied it is probably best set to all buttons rather than just .btn-success. Would also need to be set a good bit wider to avoid every second button's text wrapping.
Alternatively we can just apply this width to where it was originally intended (New) with not max width.
No max-width is good for other languages than English
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-03 11:15:38 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15578
closed as having PR #15760
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15578.
While it's definitely changed, I don't think I'd call this a B/C break. Otherwise you could argue the entire template refresh falls into that category too. Honestly, I think this boils down to what gives better UX; the ability for a dev to create a toolbar button that can go pretty wide (let's say 250-300px for the sake of argument) or the template locking a max width and creating a multi-row appearance like this one does.