? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
25 Apr 2017

Summary of Changes

This PR does the following:

  • Fix the styling for some menu views
  • Removes unused inline CSS from com_menus
  • Moves rest of inline CSS and JS from com_menus to separate files
  • Fix JS error in associations-edit.js when creating a new menu item

Testing Instructions

As this is primarily a Javascript focused PR, create a new menu item, set the type and ensure there are no errors.

The CSS stuff is simply a code review

avatar C-Lodder C-Lodder - open - 25 Apr 2017
avatar C-Lodder C-Lodder - change - 25 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2017
Category Administration com_menus Layout JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

I have tested this item successfully on 035eeef

Test: Created new Menu Item, saved, view in Browser-Concole on JavaScript-Errors.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15535.

avatar dgt41
dgt41 - comment - 25 Apr 2017

I have tested this item successfully on 035eeef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15535.

avatar dgt41 dgt41 - test_item - 25 Apr 2017 - Tested successfully
avatar dgt41 dgt41 - change - 25 Apr 2017
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 25 Apr 2017

RTC

@wilsonge

avatar wilsonge wilsonge - close - 25 Apr 2017
avatar wilsonge wilsonge - merge - 25 Apr 2017
avatar wilsonge wilsonge - change - 25 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-25 15:22:07
Closed_By wilsonge
Labels Added: ?

Add a Comment

Login with GitHub to post a comment