[#15533] - [4.0] Javascript clean up
- Closed
- 24 May 2017
- Medium
- Build: 4.0-dev
- # 15533
- Diff
- dgt41:####js-fixes
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- remove or move code out of core.js
- Rename global functions to Joomla.functionName (for testing and because it's not nice to pollute to have global functions)
- fix the multi select console error
Testing Instructions
Apply patch and test any list view (e.g. articles that ALL the links, buttons work as expected)
Try the sendmail in Global Configuration
And also in the global configuration [System Settings] try the button refresh for the Help Server
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript |
| Labels |
Added:
?
|
||
| Category | Libraries JavaScript | ⇒ | Libraries JavaScript Unit Tests |
| Labels |
Added:
?
|
||
I have tested this item
So in the articles view in com_content when I click on the publish/unpublish and feature toggle buttons in the status column an error occurs.
Also when I order by status for instance and when hovering on other buttons like the ones on the status column another error occurs. Try hovering around and clicking to replicate this.
Regarding the rest of the buttons and links I've tried several of them and all seems to be working fine.
The rest (send mail and refresh help server) I'm not sure if it is working fine, not sure if the behaviour I've witnessed is the expected one.
Regarding the send mail part no errors in the console happened but an error message popped up, not sure if that was the expected behaviour:
And finally regarding the help server refresh no JS errors spotted and nothing happened on click, also not sure if this was the intended behaviour.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15533.
| Category | Libraries JavaScript Unit Tests | ⇒ | Administration com_contact com_content com_contenthistory com_messages com_redirect Libraries JavaScript Unit Tests |
Ah ok nice! :)
The last two I was a bit unsure. I'll test again to check the other two bugs.
I have tested this item
There is still an error, a different one this time, in those same two buttons from the status column:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15533.
I have tested this item
Problem has been solved, the two buttons on the status column are now working and no errors were spotted on console.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15533.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15533.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Can we deprecate the core.js and fix conflicts please?
Can we deprecate the core.js
The idea is to clean up the bloated code from core.js, rename that file to joomla.js or system.js and also introduce JHtml::_('behavior.system') (or something like that. So in short, core.js will be the same as 3.7
The main thing with the javascript is to establish a strategy to create the final files
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
I will redo this one later on..
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 21:03:11 |
| Closed_By | ⇒ | dgt41 | |
| Labels | |||
Working so far: