? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
24 Apr 2017

Summary of Changes

This PR fixes the styling for the Smart Search (Filter View) and replaces that lovely jQuery with vanilla JS.

Testing Instructions

  • Apply PR
  • Go to Components >> Smart Search >> Filter >> New
  • Ensure the styling is ok
  • Ensure clicking the Toggle buttons checks/unchecks the checkboxes

Note that the Expand/Collapse button in the top right has a JS error caused by Bootstrap Alpha 6 and will be fixed in Beta 1

avatar C-Lodder C-Lodder - open - 24 Apr 2017
avatar C-Lodder C-Lodder - change - 24 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2017
Category Administration com_finder Front End JavaScript
avatar C-Lodder C-Lodder - change - 24 Apr 2017
Labels Added: ?
avatar rjcf18 rjcf18 - test_item - 24 Apr 2017 - Tested successfully
avatar rjcf18
rjcf18 - comment - 24 Apr 2017

I have tested this item successfully on 933e6dd

I've clicked around in the toggle buttons and in the expand/collapse buttons and everything seems to be fine. Also confirm the mentioned JS error in the expand/collapse buttons due to Bootstrap Alpha 6.

deepinscreenshot20170424233706

deepinscreenshot20170424233931


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15511.
avatar wilsonge wilsonge - change - 25 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-25 08:41:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Apr 2017
avatar wilsonge wilsonge - merge - 25 Apr 2017

Add a Comment

Login with GitHub to post a comment