Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#15505] - [4.0] [com_banners] Rewrite jQuery in vanilla JS

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
24 Apr 2017

Summary of Changes

This PR moves the inline JS from com_banners to a separate file and has been rewritten in vanilla JS

Testing Instructions

  • Apply PR
  • Go to Components >> Banners >> New (or open existing)
  • Switch the type between Image and Custom

When Image is selected, the following fields should be visible below:

Image, Width, Height, Alt Text

When Custom is selected, the following fields should be visible below:

Custom Code

So exactly the same behaviour as before.

avatar C-Lodder C-Lodder - open - 24 Apr 2017
avatar C-Lodder C-Lodder - change - 24 Apr 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2017
Category ⇒ Administration com_banners JavaScript
avatar C-Lodder C-Lodder - change - 24 Apr 2017
Labels Added: ?
avatar dgt41
dgt41 - comment - 24 Apr 2017

@wilsonge merge this!

avatar wilsonge wilsonge - change - 24 Apr 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-04-24 12:14:59
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 24 Apr 2017
avatar wilsonge wilsonge - merge - 24 Apr 2017

Add a Comment

Login with GitHub to post a comment