? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
21 Apr 2017

Summary of Changes

Those submitting PR's may have additional languages installed, so this PR will ignore all languages apart from en-GB.

Just makes life a little easier by being able to do git add . rather than having to manually add individual folders.

@mbabker this seem ok?

avatar C-Lodder C-Lodder - open - 21 Apr 2017
avatar C-Lodder C-Lodder - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Repository
avatar mbabker
mbabker - comment - 21 Apr 2017

I'd merge it to staging but seems fine to me.

avatar mbabker
mbabker - comment - 21 Apr 2017

Also, we need to make sure that the (administrator)/language/overrides/index.html files stay unignored so we don't lose those.

avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

That files isn't affected by installing/uninstalling a language

avatar zero-24
zero-24 - comment - 21 Apr 2017

@C-Lodder yes but you are ignoring it with this rule

+administrator/language/*

avatar zero-24
zero-24 - comment - 21 Apr 2017

so we need to add a rule to not ignore that file ;)

avatar C-Lodder C-Lodder - change - 21 Apr 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

hmm ok done. does someone want to change the base branch?

avatar zero-24
zero-24 - comment - 21 Apr 2017

done can you rebase @C-Lodder ?

avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

@zero-24 done

avatar zero-24
zero-24 - comment - 21 Apr 2017

@C-Lodder you have just reverted my change ;) I think the easiest thing would be a new PR against staging ?

avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

haha sorry, will do now

avatar C-Lodder C-Lodder - change - 21 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-21 16:12:53
Closed_By C-Lodder
avatar C-Lodder C-Lodder - close - 21 Apr 2017
avatar zero-24
zero-24 - comment - 21 Apr 2017

? Thanks!

Add a Comment

Login with GitHub to post a comment