Feeling Lucky
?
[#15455] - [4.0]Kill hathor support code in list models
- Fixed in Code Base
- 29 Apr 2017
- Medium
- Build: 4.0-dev
- # 15455
- Diff
- joomdonation:kill-hathor-support-code
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
For backend component model classes which extends JModelList, the model states are populated automatically in populateState method of JModelList.
However, we still had to set model states manually in every model lists class to support hathor template. Now, that template is removed in Joomla 4, we can remove these code
Testing Instructions
There are some components affected by this change. Since change is the same for all components, you can pick one component to test (For example.com_content).
- Install Joomla 4 (with sample data for easier testing)
- Access to Articles management screen
- Use search tool (enter keyword to search, select a category...), see the list of articles changed and filtered properly
- Navigate to a different component (for example, cpanel of administrator area)
- Access to Articles management screen screen again, make sure the data you entered in search tool (keyword, selected category...) still keep it's previous value.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_languages com_messages com_newsfeeds com_plugins com_redirect com_search com_tags com_users |
| Title |
|
||||||
| Labels |
Added:
?
|
||
wilsonge
- comment
- 29 Apr 2017
Thanks. I've just fixed the CS issue in the 4.0 branch :)
joomdonation
- comment
- 29 Apr 2017
Yes, good now !
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-29 14:34:26 |
| Closed_By | ⇒ | wilsonge |
Can you fix conflicts please?