User tests: Successful: Unsuccessful:
Pull Request for no issue.
This PR adds the "IF EXISTS" condition to all "CREATE TABLE" statements in any SQL scripts for Postgresql as supported since Postgresql version 9.1, so the Postgresql SQL scripts work in the same way as the SQL scripts for mysql.
See http://stackoverflow.com/questions/1766046/postgresql-create-table-if-not-exists and https://www.postgresql.org/docs/9.2/static/sql-createtable.html regarding the "CREATE TABLE IF EXISTS" support in Postgresql.
Following kinds of scripts are affected:
These 3 kinds of changes have been added with separate commits so they can be cherry-picked by a maintainer if this PR is not acceptable completely, e.g. in case PLT hates changes on old schema update SQL scripts.
The database schema manager's change item class for Postgresql already supports the "CREATE TABLE IF EXISTS" statements and so does not need to be changed, see https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/CMS/Schema/ChangeItem/PostgresqlChangeItem.php#L194
All works like before, result is same as without this PR.
Same as expected result.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Postgresql SQL Administration com_admin com_finder Installation |
Added half sentence to explain motivation of this PR (make SQL scripts for Postgresql work the same way as for mysql).
Typo corrected.
looks good from review but why do you send this against 4.0-dev and not staging (to be included in 3.7.1?
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-21 13:17:46 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Corrected grammar in description.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15446.