[#15445] - [4.0] Fix + Simplify code of frontend module editing
- Fixed in Code Base
- 23 Apr 2017
- Medium
- Build: 4.0-dev
- # 15445
- Diff
- joomdonation:fontend-module-editing
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
com_config (frontend) has really strange code. Instead of calling backend model getItem() method to get the module data, it uses complicated code by calling controller display method to get json view data.
This PR fixes that strange code. As a result, the json view + some code in com_modules is removed, too.
Testing Instructions
- Install Joomla 4 (with sample data for easier testing)
- Login to frontend using a super admin account
- Try to edit a module
- Before patch, no form display to allow edit module parameters
- After patch, a form displayed to allow changing module parameter. Save the module data, make sure the changes parameter is saved.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Front End com_config |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445.
zero-24
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Many thanks for testing @franz-wohlkoenig , @richard67 .
Is there a reason this can't go into staging (but you'd need to leave the view.json.php in place and deprecate it for j4
@wilsonge Only the change in display controller of com_config can go into stagging. Since we have to keep the file view.json.php, the code in module controller class will need to be kept as well
Do we really need to deprecate the view.json.php class? We will namespace com_modules, so that class won't be available in Joomla4 anyway, so I think it doesn't need to be deprecated?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-23 10:56:29 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
I have tested this item✅ successfully on dc3b333
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15445.