Feeling Lucky
?
?
[#15388] - Move JHttpFactory::getHttp() into try catch and add error handling
- Closed
- 14 Aug 2017
- Medium
- Build: staging
- # 15388
- Diff
- zero-24:movehttptotrycatch
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
Move any usage of JHttpFactory::getHttp() into try catch and add error handling
Testing Instructions
Review.
Confirm that you can still uses a feed.
Confirm that recaptcha still works.
Expected result
everything still works
Actual result
everything works but without error handling
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Libraries Front End Plugins |
| Labels |
Added:
?
|
||
zero-24
- comment
- 11 Jun 2017
drone is happy now. So we can start testing here?
| Category | Administration com_config Libraries Front End Plugins | ⇒ | Unit Tests Repository Administration com_admin SQL |
zero-24
- comment
- 14 Aug 2017
I'm going to trash that PR and redo it from scratch.. something did broken this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-14 14:10:52 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Can we get tests that captcha is still loading and using of a feed still works?