Feeling Lucky
?
[#15371] - [4.0] Clean up the editors
- Closed
- 7 May 2017
- Medium
- Build: 4.0-dev
- # 15371
- Diff
- dgt41:005-clean-up-editors
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Fix various bugs,
- Remove deprecated code (php side)
- Remove deprecated code (js side)
Testing Instructions
Apply patch, select none as your editor check that all the buttons work correctly and the content is saved on clicking the save button.
Repeat for Codemirror and TinyMCE
Expected result
Actual result
Documentation Changes Required
nope!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript External Library Front End Plugins |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Category | Libraries JavaScript External Library Front End Plugins | ⇒ | Libraries JavaScript External Library |
| Category | Libraries JavaScript External Library | ⇒ | Layout Libraries JavaScript External Library |
| Category | Libraries JavaScript External Library Layout | ⇒ | Layout Libraries JavaScript External Library Front End Plugins |
C-Lodder
- comment
- 25 Apr 2017
- Codemirror
- None
- TinyMCE
C-Lodder
- comment
- 27 Apr 2017
Will do in an hour. Got some work to finish up
dgt41
- comment
- 7 May 2017
I will redo this in smaller chunks
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-07 12:53:21 |
| Closed_By | ⇒ | dgt41 |
wilsonge
- comment
- 8 May 2017
Sorry this largely looked ok. But I didn't get time to test what happened to tiny on upgrade when we removed all the legacy config handling code. As I said to you on skype - I don't mind if some things change. But it needs to not be totally screwed (which is what I needed to check)
I have tested this item✅ successfully on f0ec2b1
Test using None, Codemirror and TinyMCE.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15371.