[#15364] - [4.0] Simplify for loop in articles model
- Closed
- 22 Oct 2017
- Medium
- Build: 4.0-dev
- Easy Test
- # 15364
- Diff
- bembelimen:patch-24
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Just a small code improvement: Use foreach instead of a complex for loop (so we always use the correct key)
Testing Instructions
The backend articles view should work exactly the same before and after the patch
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_content |
| Easy | No | ⇒ | Yes |
I have tested this item
see comment on #15363
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
@franz-wohlkoenig @rdeutz could you test again please?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
somehow patchtester doesn´t fetch this one ?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
@coolcat-creations you have com_patchtester(beta3) installed?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
@franz-wohlkoenig just updated it from beta 3... it just does not catch this and another one... some patches i could test already
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
@coolcat-creations can you reinstall 4.0-dev? This helps me most if something doesn't work cause i updated per nightly Builds.
it was a brandnew installation due to "make it happen" here in krakow... it´s just this issue not in the patch-list...
i´ll try again in with a new installation next days....
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-01 19:16:29 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Closed | ⇒ | Pending |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15364
closed in favor of Pull Request #18183
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2017-10-01 19:16:29 | ⇒ | 2017-10-01 19:17:14 |
| Closed_By | joomla-cms-bot | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-10-01 19:17:14 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Status | New | ⇒ | Pending |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15364
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-22 12:29:17 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Closed | ⇒ | Pending |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15364
| Status | Known Issue | ⇒ | Closed |
| Closed_Date | 2017-10-22 12:30:41 | ⇒ | 2017-10-22 12:30:42 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Pending | ⇒ | Known Issue |
| Closed_Date | 2017-10-22 12:29:17 | ⇒ | 2017-10-22 12:30:41 |
| Closed_By | joomla-cms-bot | ⇒ | franz-wohlkoenig |
| Status | Closed | ⇒ | Pending |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15364
@mbabker cannot close this PR, it always get reopend by joomla-cms-bot.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.
mbabker
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 2017-10-22 12:30:42 | ⇒ | 2017-10-22 14:46:59 |
| Closed_By | joomla-cms-bot | ⇒ | mbabker |
I have tested this item✅ successfully on ebdde82
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15364.