[#15363] - Simplify for loop in articles model
- Fixed in Code Base
- 8 Jun 2017
- Medium
- Build: staging
- Easy Test
- # 15363
- Diff
- bembelimen:patch-23
User tests: Successful: Unsuccessful:
Summary of Changes
Just a small code improvement: Use foreach instead of a complex for loop (so we always use the correct key)
Testing Instructions
The backend articles view should work exactly the same before and after the patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
| Easy | No | ⇒ | Yes |
I have tested this item
That will not work and is not a really good change:
- foreach makes a copy of the array so after the change we will use more memory
- because foreach makes a copy unset has not effect on the original array
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15363.
foreach ($items as $x => &$item) should solve the issue with the copy (from memory, not tested).
I did not change the unset line. It is still executed on the original variable, so no need for a reference...
Additional now we are sure, that the key is the correct one. In the old version we guessed the key
ah now I see what you are doing, but then I would do it different
foreach (array_keys($items) as $key) ....
@bembelimen how to go on with this PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15363.
| Labels |
Added:
?
|
||
Updated
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15363.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15363.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-08 06:49:38 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on bab4950
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15363.