Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#15236] - [4.0] Fixes the picking of things from the modal

? Success

User tests: Successful: Unsuccessful:

avatar jjaracz
jjaracz
11 Apr 2017

Summary of Changes

This PR corrects an error at the user type field.

Testing Instructions

Search for field of type user. For example you can find one at this path:
Components -> Contacts -> Contacts -> New
There is a field of name "Linked user".

Expected result

You should be able to select a user from modal and see his full user name in the box.

avatar jjaracz jjaracz - open - 11 Apr 2017
avatar jjaracz jjaracz - change - 11 Apr 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Category ⇒ JavaScript
avatar jjaracz jjaracz - change - 11 Apr 2017
Title
…
Fixes the picking of things from the modal
[4.0] Fixes the picking of things from the modal
avatar jjaracz jjaracz - change - 11 Apr 2017
Title
…
Fixes the picking of things from the modal
[4.0] Fixes the picking of things from the modal
avatar jjaracz jjaracz - edited - 11 Apr 2017
avatar jjaracz jjaracz - change - 11 Apr 2017
The description was changed
avatar jjaracz jjaracz - edited - 11 Apr 2017
avatar wilsonge
wilsonge - comment - 11 Apr 2017

@dgt41 JavaScript guru evaluation required please :)

avatar C-Lodder
C-Lodder - comment - 12 Apr 2017

Despite the reviews, fielduser.js really needs to be vanillarised.

avatar jjaracz jjaracz - change - 15 Apr 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2017
Category JavaScript ⇒ Layout JavaScript
avatar jjaracz
jjaracz - comment - 15 Apr 2017

Thank you @C-Lodder for your reviews ?

I had to replace jquery with a pure js to load iframe, because there was an error in this version of jquery.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2017
Category JavaScript Layout ⇒ Administration com_users Layout JavaScript
avatar C-Lodder
C-Lodder - comment - 24 May 2017

@jjaracz - would you mind fixing the conflicts so this can be tested please?

avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar laoneo
laoneo - comment - 3 Apr 2018

Can you fix the conflicts please.

avatar sanderpotjer
sanderpotjer - comment - 5 May 2019

@wilsonge no activity for over a year, needs additional work and merge conflicts: close this one?

avatar wilsonge
wilsonge - comment - 5 May 2019

Yup this seems to be working in the current 4.0 branch so closing

avatar wilsonge wilsonge - change - 5 May 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-05 13:51:14
Closed_By ⇒ wilsonge
Labels Removed: J4 Issue
avatar wilsonge wilsonge - close - 5 May 2019

Add a Comment

Login with GitHub to post a comment