You are correct the strings are less than optimal. I am away from computer until tomorrow

Thanks!

RC1 is released and that also means language freeze is in effect now.

i couldnt get the message to display on an existing site. Maybe I misunderstood something in the instructions.

I reviewed the messages based on a clean install using https://github.com/zero-24/joomla-cms/archive/hathor_postinstall.zip

From reading code the postinstall message only shows when Hathor is the default template.
We probably should also check the user settings, or just check the active template.

The action method is wrong as it would set all styles from Isis as default. It must only set one style as default.
Also we should take care of user settings here as well.

I think we should show this message regardless if the user has set hathor as default or not. The messages should be "don't use hathor as the default, if you use it for specific tasks or users make sure it works, we strongly recommend isis"

The action method is wrong as it would set all styles from Isis as default. It must only set one style as default.

Got it. What do you suggest? The problem is we can't reley on the ID or the text "isis - Default". We can also change this so the button send you to the backend view to change it manually.

As maybe you have removed or renamed the default isis style.

Also we should take care of user settings here as well.

What do you mean exactly? I don't agree we are allowed to change any default style for all users. (Given the problem above too.)

I think we should show this message regardless if the user has set hathor as default or not.

The problem is that we don't show this message to all backend users just for superadmins and users with the correct permissions.

But we can show the message with return true; always to all this users.
But this would also mean we need to reword the message.

To avoid issues with styles, I would not add a button to switch to Isis. Just a link to the Template styles page.

Perhaps it should also be mentioned in the text string that it is removed in Joomla 4?

I am not understanding why we decided to keep it when it is well known that it is broken for sure. There is nothing for the users to make sure about.

This probably because I am not aware of all the considerations taken into account for that PLT decision. Appreciate if somebody can explain.

As mentioned by @zero-24 in #15107 (comment), We can't remove Hathor in the postinstall action too. A user cannot remove it manually too, as it comes back.
Why force to keep something that won't work anyway!

There is a purpose for the template, if someone is using it just for simple things like edit content then it works, it is only a problem when you do more complicated things like menu, associations, custom fields. If we remove it entirely then these people have to change but in fact there is no need.

@rdeutz Hmm. That makes sense. Now the tough part for those users is to understand what falls under those "simple things" and what not.

The problem is we can't reley on the ID or the text "isis - Default". We can also change this so the button send you to the backend view to change it manually.

Just take the first style you find for the Isis template. That can be done with a query and with a second one you can set it. It shouldn't matter much which style we make default if there are multiple. All of them will work.

What do you mean exactly? I don't agree we are allowed to change any default style for all users. (Given the problem above too.)

I mean if a user presses the button, and that user has the template set to Hathor in his preferences, then the button pressing currently will have no effect for him. He will think the button is broken.
So we need to change the settings for the user pressing the button. I wouldn't change it for all users, just for the active one. And I wouldn't use a direct query. Instead load the user, change the param using JRegistry and then save the user again. This way it's a save way.

The problem is that we don't show this message to all backend users just for superadmins and users with the correct permissions.

I would show it for all users with access to postinstalls.

To avoid issues with styles, I would not add a button to switch to Isis. Just a link to the Template styles page.
That would simplify the whole process, including not touching at the sqls

Then you need to first make sure the user can actually access that link. The query would work even if the user doesn't have access to the styles.

Perhaps it should also be mentioned in the text string that it is removed in Joomla 4?

I don't think that this needs mentioning. Isis will be removed as well and replaced with a new one. So there is no difference :)

@rdeutz there have been claims that Hathor was created with the intent of being intended for web accessibility like a11y, if that was true there was a point for Hathor in the past. Unfortunately, it's a poorly executed solution that no longer meets its design intent.

It was done with that goal in mind in Joomla 2.5. The template never got properly adjusted for Joomla 3.

@photodude I agree

I mean if a user presses the button, and that user has the template set to Hathor in his preferences, then the button pressing currently will have no effect for him. He will think the button is broken.
So we need to change the settings for the user pressing the button. I wouldn't change it for all users, just for the active one. And I wouldn't use a direct query. Instead load the user, change the param using JRegistry and then save the user again. This way it's a save way.

Done.

How to trigger the message

You have access to the global style settings

The system wide template is hathor and you have the right access to change the default style, as well as having access to postinstall. ;)

You don't have access to the global setting

Your local / style is from the hathor template and you have access to postinstall.

What the button does

You have access to the global style settings

The button sets the global style stettings to the first on of isis (should be the original) as well as the user setting if needed.

You don't have access to the global setting

We only change your user setting.

I have also changed the language string

TPL_HATHOR_MESSAGE_POSTINSTALL_BODY="Currently the Hathor administrator template style is set as your personal or global default administrator template. Please note - any new features for Joomla will only be available with the Isis template. We recommend that you switch your default backend template style to Isis. You can do this by selecting the button below. This will only change the default setting for the administrator template, if you have access to it, as well as your personal default style, if necessary. It does not change the frontend template or others individual user settings."

To match the new behavior with the button, please review / improve.

Sounds good! ?

@alikon can we just get a quick postgress and mssql review from you?

it seems ok to me

Thanks!

Pr to fix the new English will come tomorrow

On 11 Apr 2017 8:21 p.m., "zero-24" notifications@github.com wrote:

Thanks!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#15210 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bJqlSyObk0F4qKxzFBhXH5WR3H1ks5ru9K_gaJpZM4M5JVA
.