? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
5 Apr 2017

Version 4.5.6 (2017-03-30)

  • Fixed bug where it wasn't possible to select floated images in some cases.
avatar C-Lodder C-Lodder - open - 5 Apr 2017
avatar C-Lodder C-Lodder - change - 5 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Apr 2017
Category JavaScript Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Apr 2017

try installing PR, got: Error The file marked for modification does not exist: grunt_settings.yaml


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15106.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Apr 2017

sorry, was on 3.7

On 4.0 got: Error Could not connect to GitHub: This API returns blobs up to 1 MB in size. The requested blob is too large to fetch via the API, but you can use the Git Data API to request blobs up to 100 MB in size.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15106.

avatar mbabker
mbabker - comment - 7 Apr 2017

You won't be able to test this with patch tester then. It's either a new restriction on GitHub's API or something about the size of TinyMCE, but its base JavaScript is definitely too large for the API.

avatar C-Lodder
C-Lodder - comment - 7 Apr 2017

can't see what the issue would be considering only 28 lines of code were changed

avatar dgt41
dgt41 - comment - 7 Apr 2017

tiny is totally broken in J4!

avatar C-Lodder
C-Lodder - comment - 7 Apr 2017

Not for me @dgt41

avatar dgt41
dgt41 - comment - 7 Apr 2017

can you save content?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Apr 2017

@C-Lodder #15091 is RTC now.

avatar C-Lodder
C-Lodder - comment - 7 Apr 2017

ah no, says it's saved but doesn't update

avatar dgt41
dgt41 - comment - 7 Apr 2017

a pretty foobar editor ;)

avatar mbabker
mbabker - comment - 7 Apr 2017

can't see what the issue would be considering only 28 lines of code were changed.

Patch tester isn't patching files. It downloads and replaces full files. Patch tester can't do patches, it would require information about the git environment the Joomla build is based on to get the correct patch path and that's too impractical.

avatar wilsonge wilsonge - change - 7 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-07 20:08:07
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 7 Apr 2017
avatar wilsonge wilsonge - merge - 7 Apr 2017

Add a Comment

Login with GitHub to post a comment