[#15099] - [sql install] Set all front menu modules to display sub menus per default when installing Joomla
- Fixed in Code Base
- 6 Apr 2017
- Medium
- Build: staging
- # 15099
- infograf768:sub_menus_modules
Pull Request for Issue #15094
Summary of Changes
As title says.
When creating a frontend menu module the default is to show the sub menus.
<field
name="showAllChildren"
type="radio"
label="MOD_MENU_FIELD_ALLCHILDREN_LABEL"
description="MOD_MENU_FIELD_ALLCHILDREN_DESC"
class="btn-group btn-group-yesno"
default="1"
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
This normalises this setting in all sample data.
I see no unwanted consequences: when no submenus available, no change.
Testing Instructions
Patch an instance of Joomla and install with various sample data
This can also be tested using this pack
https://github.com/infograf768/joomla-cms/archive/sub_menus_modules.zip
It's indeed mostly code review, but you can check is none or any sample data installs ok, and then look at the menu modules to confirm that Sub Menu Items parameter is set to Yes.
tested successfully (didn't get Button on Issue Tracker to mark)
| Category | ⇒ | Installation SQL |
| Status | New | ⇒ | Confirmed |
| Status | Confirmed | ⇒ | Pending |
We need one more tester.
Tested successfully via code review.
Should this file be updated too?
\joomla-cms\tests\unit\stubs\database\jos_modules.csv
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15099.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-06 07:53:54 |
| Closed_By | ⇒ | rdeutz |
joomla-cms-bot
- | Category | Installation SQL | ⇒ | SQL Installation Postgresql MS SQL |
see its an complete install. Test now.