User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_finder com_templates Front End |
Do NOT take off the class from
administrator/components/com_finder/views/filter/tmpl/edit.php
but combine them as I did in #15092
Do not modify components/com_finder/helpers/html/filter.php and leave it alone.
These are used both by Isis AND Hathor!.
OK for the change in administrator/components/com_templates/views/style/tmpl/edit_assignment.php as this one is overriden by Hathot
Seeing as this is used for Hathor, which already has it's own float classes, jform-rightbtn
can be replaced with fltrt
.
I suggest to wait for a decision concerning Hathor.
See https://issues.joomla.org/tracker/joomla-cms/15079
Rel_Number | ⇒ | 15079 | |
Relation Type | ⇒ | Not before |
@infograf768 Decision is made (comment by @wilsonge): "There has been a decision made. Hathor will continue to ship with J3.x however we do not guarantee feature parity of all Joomla features (i.e. everything that works now should continue to work but we don't guarantee new features like fields and associations etc will continue to work fully - although we won't obviously reject any PR's if they come in)"
@franz-wohlkoenig
yep, i know that. but we should not kill what works fine either.
i have no issue if hathor is corrected at the same time.
@infograf768 so this PR should be closed?
it alreadt has conflicts, so i think it should be updated, and include the hathor changes. these are not new features, but css matters.
I will open a new pr.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 15:40:27 |
Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on effa15c
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097.