Pending
Not before # 15079

User tests: Successful: Unsuccessful:

avatar Quy
Quy
4 Apr 2017

Summary of Changes

From #15092, per @C-Lodder, this class is not needed.

Testing Instructions

Code review.

avatar Quy Quy - open - 4 Apr 2017
avatar Quy Quy - change - 4 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2017
Category Administration com_finder com_templates Front End
avatar RonakParmar RonakParmar - test_item - 5 Apr 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 5 Apr 2017

I have tested this item successfully on effa15c

Done code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097.

avatar infograf768
infograf768 - comment - 5 Apr 2017

Do NOT take off the class from
administrator/components/com_finder/views/filter/tmpl/edit.php
but combine them as I did in #15092

Do not modify components/com_finder/helpers/html/filter.php and leave it alone.

These are used both by Isis AND Hathor!.

OK for the change in administrator/components/com_templates/views/style/tmpl/edit_assignment.php as this one is overriden by Hathot

avatar C-Lodder
C-Lodder - comment - 5 Apr 2017

Seeing as this is used for Hathor, which already has it's own float classes, jform-rightbtn can be replaced with fltrt.

avatar infograf768
infograf768 - comment - 5 Apr 2017

I suggest to wait for a decision concerning Hathor.

See https://issues.joomla.org/tracker/joomla-cms/15079


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097.

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Apr 2017
Rel_Number 15079
Relation Type Not before
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 May 2017

@infograf768 Decision is made (comment by @wilsonge): "There has been a decision made. Hathor will continue to ship with J3.x however we do not guarantee feature parity of all Joomla features (i.e. everything that works now should continue to work but we don't guarantee new features like fields and associations etc will continue to work fully - although we won't obviously reject any PR's if they come in)"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15097.

avatar infograf768
infograf768 - comment - 24 May 2017

@franz-wohlkoenig
yep, i know that. but we should not kill what works fine either.
i have no issue if hathor is corrected at the same time.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 May 2017

@infograf768 so this PR should be closed?

avatar infograf768
infograf768 - comment - 24 May 2017

it alreadt has conflicts, so i think it should be updated, and include the hathor changes. these are not new features, but css matters.

avatar Quy
Quy - comment - 24 May 2017

I will open a new pr.

avatar Quy Quy - change - 24 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-24 15:40:27
Closed_By Quy
avatar Quy Quy - close - 24 May 2017

Add a Comment

Login with GitHub to post a comment