? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
4 Apr 2017

Pull Request for Issue #15080 .

Summary of Changes

Since w removed the context from the #__fields_values table, we need to check the context from the #__fields table now.
Also the property got renamed from fields to jcfields.

Testing Instructions

Search for a field value in an article.

Expected result

Article shows up

Actual result

Error message

Documentation Changes Required

None

avatar Bakual Bakual - open - 4 Apr 2017
avatar Bakual Bakual - change - 4 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2017
Category Front End Plugins
avatar Bakual Bakual - change - 4 Apr 2017
Title
Fix search query due to removed context and renamed field property.
[com_fields] Fix search query due to removed context and renamed field property.
avatar Bakual Bakual - edited - 4 Apr 2017
avatar AlexRed AlexRed - test_item - 4 Apr 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 4 Apr 2017

I have tested this item successfully on c4d0c5c

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15086.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

Without PR: Search for an Field-Value (en-GB) on a multi.-lang. Site using Menu Smart Search (en-GB) Article is found.

avatar jsubri
jsubri - comment - 4 Apr 2017

Looks good on mono-lingual website.
However on multi-lingual index.php/nl/component/search/?searchword=dutch&searchphrase=all returns 6 rows while the index.php/fr/component/search/?searchword=dutch&searchphrase=all returns 0 rows.
I need to check what was the 3.6.5 behaviour to be able to confirm the fix.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

i tested on latest staging 3.7.

avatar Bakual
Bakual - comment - 4 Apr 2017

Site using Menu Smart Search (en-GB) Article is found.

This would be about the standard search, not the Smart Search

However on multi-lingual index.php/nl/component/search/?searchword=dutch&searchphrase=all returns 6 rows with my data while the index.php/fr/component/search/?searchword=dutch&searchphrase=all returns 0 rows.
I need to check what was the 3.6.5 behaviour to be able to confirm the fix.

Search is performed on active language only. So if your articles are assigned to dutch, then this would be expected behavior.

avatar jsubri jsubri - test_item - 4 Apr 2017 - Tested successfully
avatar jsubri
jsubri - comment - 4 Apr 2017

I have tested this item successfully on c4d0c5c

Works fine on mysql, same behaviour as 3.6.5 mono and multi-lingual
Thank you all.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15086.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

RTC after two successful testes.

avatar rdeutz rdeutz - change - 4 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-04 19:09:08
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 4 Apr 2017
avatar rdeutz rdeutz - merge - 4 Apr 2017

Add a Comment

Login with GitHub to post a comment