? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
4 Apr 2017

Move Application classes to namespace. Additionally it reverts #15081 as the namespace needs to be adopted as well.

avatar laoneo laoneo - open - 4 Apr 2017
avatar laoneo laoneo - change - 4 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2017
Category Libraries
avatar laoneo laoneo - change - 4 Apr 2017
Labels Added: ?
26f8ab2 4 Apr 2017 avatar laoneo CS
avatar laoneo laoneo - change - 4 Apr 2017
The description was changed
avatar laoneo laoneo - edited - 4 Apr 2017
avatar wilsonge
wilsonge - comment - 4 Apr 2017

You need to run composer install --no-dev

avatar laoneo
laoneo - comment - 4 Apr 2017

Why, it's not related to composer, just fixes #15081.

avatar brianteeman
brianteeman - comment - 4 Apr 2017

dont forget that I really messed up with 15081 and not only did i accidentally merge it I then committed directly as well https://github.com/joomla/joomla-cms/commits/3.8-dev

avatar laoneo
laoneo - comment - 4 Apr 2017

I guess you guys want to head on with CMS and not Cms so I'm fixing that in this pr as well because at the moment it is completely broken, in every file, classes with Cms are used and not CMS.

avatar brianteeman
brianteeman - comment - 4 Apr 2017

sorry

avatar brianteeman
brianteeman - comment - 4 Apr 2017

I will not touch git after midnight again

avatar laoneo
laoneo - comment - 4 Apr 2017

No problem...

avatar laoneo
laoneo - comment - 4 Apr 2017

So all should be fine now, fixed the tests as well.

avatar laoneo
laoneo - comment - 4 Apr 2017

Done. Dunno why that happened.

avatar wilsonge wilsonge - change - 4 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-04 11:31:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Apr 2017
avatar wilsonge wilsonge - merge - 4 Apr 2017

Add a Comment

Login with GitHub to post a comment