? ? Pending

User tests: Successful: Unsuccessful:

avatar viocassel
viocassel
3 Apr 2017

Summary of Changes

This PR updates jQuery Autocomplete library to version 1.4.0 for com_finder and mod_finder.

Testing Instructions

  1. Apply patch
  2. Test the com_finder and mod_finder typing any word in search field (for example, joomla 😉)
  3. Make sure there are no JS errors and the list dropdown displayed correctly.

Result

com_finder
com_finder

mod_finder
mod_finder

avatar viocassel viocassel - open - 3 Apr 2017
avatar viocassel viocassel - change - 3 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2017
Category JavaScript
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Apr 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Apr 2017

I have tested this item 🔴 unsuccessfully on 074c0c9

No JS-Errors in Console, but Dropdown isn't shown with PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Priority Medium Very low
Status Pending Confirmed
Easy No Yes
avatar viocassel viocassel - change - 4 Apr 2017
Title
Update jQuery Autocomplete to 1.4.0
Update jQuery Autocomplete to 1.4.1
avatar viocassel viocassel - edited - 4 Apr 2017
avatar viocassel
viocassel - comment - 4 Apr 2017

Thanks @franz-wohlkoenig
Updated to version 1.4.1.
Please try again.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

I have tested this item ✅ successfully on 58cd498


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar yasirunilan
yasirunilan - comment - 11 Apr 2017

what is meant by this ?
Test the com_finder and mod_finder typing any word in search field (for example, joomla 😉)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

@yasirunilan yes, you should test com_finder and mod_finder (see Screenshots above) if Dropdown-Field is shown correct.

avatar yasirunilan
yasirunilan - comment - 11 Apr 2017

@franz-wohlkoenig yeah. what my question was how to go to com_finder?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

for com_finder you have to create the Menu and test.

avatar yasirunilan yasirunilan - test_item - 11 Apr 2017 - Tested unsuccessfully
avatar yasirunilan
yasirunilan - comment - 11 Apr 2017

I have tested this item 🔴 unsuccessfully on 58cd498

can't see the dropdown.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar brianteeman brianteeman - test_item - 28 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Jul 2017

I have tested this item ✅ successfully on acfa0bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Jul 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

I have tested this item 🔴 unsuccessfully on acfa0bd

Smart search works, no Dropdown in Module "Search".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar brianteeman
brianteeman - comment - 29 Jul 2017

@franz-wohlkoenig are you sure you are testing the smart search component and module. They both work correctly for me. It sounds to me that you are testing the regular search module which is not related to this pr.

As a general tip if you cant confirm that something is working after a PR its always a good idea to test without the PR as well.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

I have tested this item ✅ successfully on acfa0bd

you're right, @brianteeman, i tested also module "search".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15078.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Jul 2017
Status Confirmed Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Jul 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 29 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-29 15:02:30
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Jul 2017
avatar mbabker mbabker - merge - 29 Jul 2017

Add a Comment

Login with GitHub to post a comment