? ? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
2 Apr 2017

Pull Request for Issue ##14906 .

Summary of Changes

Apart from fixing the bug in #14906 this PR also fixes another bug with the toolbar tooltip rendered in wrong position after the first image upload.
Also moves the plugin javascript code out of the tinyMCE/plugins directory (will make updates easier)

Testing Instructions

Edit the configuration and provide a custom path for the drag and drop upload, this setting is per tab option so make sure that you are using the right one!!!
Try to upload an image,
Check where the image is stored and also try to see if the tooltips in bold, italics etc is in the right position

Apply the patch and repeat

Expected result

Use the provided path

Actual result

Is not using the provided path

Documentation Changes Required

None, bug fix

avatar dgt41 dgt41 - open - 2 Apr 2017
avatar dgt41 dgt41 - change - 2 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2017
Category JavaScript External Library Front End Plugins
avatar AlexRed
AlexRed - comment - 2 Apr 2017

ok, the patch fix the bug with the editor toolbar tooltip rendered in wrong position after the first image upload.
But for me the "Images Directory" parameter tooltip need to explain you can use the "Images Directory" parameter in the TinyMCE plugin to insert a folder name (not a path). This will be automatically generated by the system on the first dragging of an image. The folder will be created as a subfolder of the one set in the media manager settings as “Path to Files Folder”. Since they are image files, I think it would be better to set that it is created as a subfolder of the one set in the media manager settings as “Path to Images Folder”.

avatar dgt41 dgt41 - change - 2 Apr 2017
Labels Added: ?
avatar dgt41
dgt41 - comment - 2 Apr 2017

The last commit transforms the inout to a drop down of possible directories, as @brianteeman suggested in the issue.
Personally I always prefer clicking instead of typing (although as a dev it should be the other way around :) )

screen shot 2017-04-02 at 19 57 12

For the tooltip text please make another PR

330dcc0 2 Apr 2017 avatar dgt41 oops
avatar AlexRed AlexRed - test_item - 2 Apr 2017 - Tested unsuccessfully
avatar AlexRed
AlexRed - comment - 2 Apr 2017

I have tested this item ? unsuccessfully on 330dcc0

no work for me.
I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar AlexRed
AlexRed - comment - 2 Apr 2017

Sorry but I can't make a PR for the en language file.. my english is very bab :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar zero-24
zero-24 - comment - 2 Apr 2017

Please add a doc block for the new method to fix drone ;)

06dd566 2 Apr 2017 avatar dgt41 CS
avatar dgt41
dgt41 - comment - 2 Apr 2017

@AlexRed thanks, that should be ok now

avatar AlexRed
AlexRed - comment - 2 Apr 2017

no more dropdown ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar dgt41
dgt41 - comment - 2 Apr 2017

It's still there for me:
screen shot 2017-04-02 at 20 56 33

avatar AlexRed
AlexRed - comment - 2 Apr 2017

sorry, dropdown ok but the image continue to go in a subfolder of Path to Files Folder in the Media: Options.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar dgt41
dgt41 - comment - 2 Apr 2017

@AlexRed are you on M$ win-dos machine?

avatar AlexRed
AlexRed - comment - 2 Apr 2017

No, linux

avatar dgt41
dgt41 - comment - 2 Apr 2017

@AlexRed so can you post your settings, in tinymce and com_media, I can't really understand why your setup is misbehaving

avatar dgt41
dgt41 - comment - 2 Apr 2017

I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/

OK, I've figured why you don't get the expected results.
The tinymce drag and drop folder is a subfolder of the folder that is set in com_media as Images folder.
The system actually behaves correctly, so it uses the "headers" from the tinyMCE options, but the base folder (before that) is from the the com_media. The last part cannot change in 3.x as it will be B/C break so you have to adjust the options in com_media that both folders point in the same directory, something like:
screen shot 2017-04-02 at 21 32 51

avatar AlexRed
AlexRed - comment - 2 Apr 2017

yes, I can. But the Joomla users when select the folder in the dropdown think the images go there... but no. The images go in a new subfolder with the same name if the user use the Path to Files Folder in the Media

avatar dgt41
dgt41 - comment - 2 Apr 2017

But the Joomla users when select the folder in the dropdown think the images go there...

This folder that they will select is always a subfolder of their images directory, maybe a better tooltip there could be more helpful

avatar AlexRed
AlexRed - comment - 2 Apr 2017

yes, also for me the tooltip text need to explain better

avatar brianteeman
brianteeman - comment - 2 Apr 2017

use the esisting PLG_FIELDS_MEDIA_PARAMS_DIRECTORY_DESC

avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2017
Category JavaScript External Library Front End Plugins Administration Language & Strings JavaScript External Library Front End Plugins
avatar dgt41
dgt41 - comment - 2 Apr 2017
9e6415a 2 Apr 2017 avatar dgt41 DRY
avatar dgt41 dgt41 - change - 2 Apr 2017
Labels Added: ?
avatar brianteeman brianteeman - test_item - 4 Apr 2017 - Not tested
avatar brianteeman
brianteeman - comment - 4 Apr 2017

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar dgt41
dgt41 - comment - 4 Apr 2017

@brianteeman was that what you wanted to select in the issue tracker?

avatar brianteeman
brianteeman - comment - 4 Apr 2017

oops no

avatar brianteeman brianteeman - test_item - 4 Apr 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 4 Apr 2017

I have tested this item successfully on 9e6415a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar AlexRed AlexRed - test_item - 4 Apr 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 4 Apr 2017

I have tested this item successfully on 9e6415a

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15057.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2017

RTC after two successful testes.

avatar rdeutz rdeutz - change - 4 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-04 19:12:50
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 4 Apr 2017
avatar rdeutz rdeutz - merge - 4 Apr 2017

Add a Comment

Login with GitHub to post a comment