User tests: Successful: Unsuccessful:
Pull Request for Issue ##14906 .
Apart from fixing the bug in #14906 this PR also fixes another bug with the toolbar tooltip rendered in wrong position after the first image upload.
Also moves the plugin javascript code out of the tinyMCE/plugins directory (will make updates easier)
Edit the configuration and provide a custom path for the drag and drop upload, this setting is per tab option so make sure that you are using the right one!!!
Try to upload an image,
Check where the image is stored and also try to see if the tooltips in bold, italics etc is in the right position
Apply the patch and repeat
Use the provided path
Is not using the provided path
None, bug fix
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript External Library Front End Plugins |
Labels |
Added:
?
|
The last commit transforms the inout to a drop down of possible directories, as @brianteeman suggested in the issue.
Personally I always prefer clicking instead of typing (although as a dev it should be the other way around :) )
For the tooltip text please make another PR
I have tested this item
no work for me.
I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/
Sorry but I can't make a PR for the en language file.. my english is very bab :(
Please add a doc block for the new method to fix drone ;)
no more dropdown ?
sorry, dropdown ok but the image continue to go in a subfolder of Path to Files Folder in the Media: Options.
No, linux
I select "headers" in the dropdown and "images/draganddrop" in Path to Files Folder in the Media: Options.
The image go in the new folder images/draganddrop/headers/
OK, I've figured why you don't get the expected results.
The tinymce drag and drop folder is a subfolder of the folder that is set in com_media as Images folder.
The system actually behaves correctly, so it uses the "headers" from the tinyMCE options, but the base folder (before that) is from the the com_media. The last part cannot change in 3.x as it will be B/C break so you have to adjust the options in com_media that both folders point in the same directory, something like:
yes, I can. But the Joomla users when select the folder in the dropdown think the images go there... but no. The images go in a new subfolder with the same name if the user use the Path to Files Folder in the Media
But the Joomla users when select the folder in the dropdown think the images go there...
This folder that they will select is always a subfolder of their images directory, maybe a better tooltip there could be more helpful
yes, also for me the tooltip text need to explain better
use the esisting PLG_FIELDS_MEDIA_PARAMS_DIRECTORY_DESC
Category | JavaScript External Library Front End Plugins | ⇒ | Administration Language & Strings JavaScript External Library Front End Plugins |
@brianteeman done
Labels |
Added:
?
|
I have not tested this item.
@brianteeman was that what you wanted to select in the issue tracker?
oops no
I have tested this item
I have tested this item
Patch ok for me
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-04 19:12:50 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
ok, the patch fix the bug with the editor toolbar tooltip rendered in wrong position after the first image upload.
But for me the "Images Directory" parameter tooltip need to explain you can use the "Images Directory" parameter in the TinyMCE plugin to insert a folder name (not a path). This will be automatically generated by the system on the first dragging of an image. The folder will be created as a subfolder of the one set in the media manager settings as “Path to Files Folder”. Since they are image files, I think it would be better to set that it is created as a subfolder of the one set in the media manager settings as “Path to Images Folder”.