? ? Pending

User tests: Successful: Unsuccessful:

avatar Paladin
Paladin
31 Mar 2017

Wrap the IndexIgnore directive in an IfModule block to prevent it from being seen by system without auto index turned on.

Pull Request for Issue ##15031 .

Summary of Changes

Wrapped it in an IfModule block

Testing Instructions

disable mod_autoindex
see if site loads

Expected result

Site should load

Actual result

Documentation Changes Required

avatar Paladin Paladin - open - 31 Mar 2017
avatar Paladin Paladin - change - 31 Mar 2017
Status New Pending
avatar zero-24 zero-24 - edited - 31 Mar 2017
avatar zero-24 zero-24 - change - 31 Mar 2017
Title
Fix htaccess.txt
Using the supplied htaccess file will crash some servers
Labels Added: ?
avatar zero-24 zero-24 - test_item - 31 Mar 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 31 Mar 2017

I have tested this item successfully on bc4ce74

works good here.

Tip for testers

If you have a local server go to \apache\conf\httpd.conf and comment (adding a # before that line) the following line:

LoadModule autoindex_module modules/mod_autoindex.so

Save the file and restart the apatche server.

Note: you can't use patchtester for this patch you need to manually add that fix to the active .htaccess.

Thanks @Paladin I have just added a tab to that file with the last commit.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15033.

avatar zero-24 zero-24 - change - 31 Mar 2017
Category Router / SEF
avatar Paladin
Paladin - comment - 31 Mar 2017

The suggestion to comment the LoadModule line given is only for specific linux distros. Most recent Ubuntu (14.04, for example) will have the module load commands in separate files (in the mods-available and mods-enabled directories) and you would use a2enmod to enable the module and a2dismod to disable. Not sure if there are others in other distros.

avatar zero-24
zero-24 - comment - 31 Mar 2017

Thanks @Paladin can you add that to the "How to test" info in your pull request? For me (local lamp stack) the path above works for me.

avatar klas klas - test_item - 31 Mar 2017 - Tested successfully
avatar klas
klas - comment - 31 Mar 2017

I have tested this item successfully on bc4ce74


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15033.

avatar zero-24 zero-24 - change - 31 Mar 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar zero-24
zero-24 - comment - 31 Mar 2017

RTC Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15033.

avatar wilsonge wilsonge - change - 3 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-03 11:01:10
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - close - 3 Apr 2017
avatar wilsonge wilsonge - merge - 3 Apr 2017
avatar wilsonge
wilsonge - comment - 3 Apr 2017

Merged - thanks!

Add a Comment

Login with GitHub to post a comment