[#15032] - [com_fields] Add a check if the default value is correct based on JFormRules
- Fixed in Code Base
- 1 Apr 2017
- Medium
- Build: staging
- Easy Test
- # 15032
- Diff
- Digital-Peak:cf/calendar-rule
User tests: Successful: Unsuccessful:
Pull Request for Issue #15005.
Summary of Changes
This pr adds support to check the default value of a custom field when a JFormRule exists. Additionally it adds support of rules for field plugins to a be found by JForm.
Testing Instructions
- Create a calendar custom field
- Set as default value
test - Save the field
Please also save the field with the following default values which should be correct:
- now
- NOW
- 2017-02-09
The same can also be tested with any other field which has a rule.
Expected result
The field is not saved and an error message is shown.
Actual result
The field saves normally.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15032.
| Labels |
Added:
?
?
|
||
Thanks!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15032.
| Easy | No | ⇒ | Yes |
Only cs commits are done, guess ready for rtc?
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
How can this be rtc when there are unresolved comments
| Labels |
Added:
?
|
||
Should be fixed now @brianteeman thanks for the reminder.
| Status | Ready to Commit | ⇒ | Pending |
RTC okay?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15032.
| Title |
|
||||||
ok now @brianteeman?
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Back to RTC after the comment by @brianteeman is resovled now and there are just cs changes between the tests
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15032.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-01 22:05:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 2158030
Test on calendar custom field: "test" brings Error, other 3 Values saved and working in Article.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15032.