? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Mar 2017

Summary of Changes

This changes the order of the errors when installing a language and creating a Content Language.

In 3.7.0/staging, a Content Language is automatically created (unpublished) when installing a language.
When uninstalling this language, the Content Language remains (which is correct behavior).
When the same language is installed again, the code checks for uniqueness of
sef
image (flag) used
Language Tag

The order is not important when editing Content Languages, but it is when reinstalling a language.

This PR reorders the errors

  1. Language Tag
  2. sef
  3. Image

After patch when reinstalling a language for which the Content Language already exists, one will get:

screen shot 2017-03-31 at 10 54 43

Instead of:
Unable to create a content language for Persian language: A content language already exists with this Image.

Thanks @imanickam for finding this issue.
Testers welcome.

avatar infograf768 infograf768 - open - 31 Mar 2017
avatar infograf768 infograf768 - change - 31 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2017
Category Libraries
avatar infograf768
infograf768 - comment - 31 Mar 2017

Please, instead of "Approved" can you mark the Test as successful on issues.joomla.org ?

avatar afk afk - test_item - 31 Mar 2017 - Tested successfully
avatar afk
afk - comment - 31 Mar 2017

I have tested this item successfully on f1b826a

Sure ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022.

avatar imanickam
imanickam - comment - 31 Mar 2017

I have tested this item successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022.

avatar infograf768 infograf768 - alter_testresult - 31 Mar 2017 - imanickam: Tested successfully
avatar imanickam
imanickam - comment - 31 Mar 2017

Tested this change successfully and also commented on Issue Tracker #15022

avatar infograf768 infograf768 - change - 31 Mar 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 31 Mar 2017

RTC. Thanks for Testing!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15022.

avatar Bakual Bakual - change - 31 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-31 10:14:44
Closed_By Bakual
Labels Added: ? ?
avatar Bakual Bakual - close - 31 Mar 2017
avatar Bakual Bakual - merge - 31 Mar 2017

Add a Comment

Login with GitHub to post a comment