[#15021] - [4.0] Allow for FA icons in toolbar buttons
- Fixed in Code Base
- 9 Apr 2017
- Very low
- Build: 4.0-dev
- Easy Test
- # 15021
- Diff
- ciar4n:toolbar-fa
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Currently the toolbar button icons are only styled for 'icon-'. This PR allows you to also use FontAwesome classes.
Testing Instructions
Navigate to view containing a toolbar (Content -> Articles). Inspect toolbar buttons and replace icon class (eg. icon-publish) with FontAwesome classes (fa fa-coffee).
Before patch
After patch
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
@franz-wohlkoenig Without and with PR try replacing the icon using font awesome classes (fa fa-coffee).
Right click icon -> Inspect
<button class="btn btn-sm btn-outline-success" ... >
<span class="fa fa-coffee"></span>
Publish
</button>
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15021.
Not sure about this, why not compile/setup your fontAwesome stuff with "icon-" instead of "fa-"? Is one line in the settings. Otherwise we have to support other prefixes, too?
To be honest, we should be supporting both. The agreement with using FA was that we still keep BC, by mapping the styling of icon-xxx to the correct FA class.
We don't need to support other prefixes for the core templates, but 3rd party template could using something like this for the front-end if they want to support a dynamic prefix for FA
[class^="icon-"],
[class*=" icon-"],
[class^="#{$fa-css-prefix}-"],
[class*=" #{$fa-css-prefix}-"] {
...
}
| Priority | Medium | ⇒ | Very low |
| Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-09 11:18:12 |
| Closed_By | ⇒ | wilsonge |
With or -out PR Toolbar looks like:
