? Pending

User tests: Successful: Unsuccessful:

avatar photodude
photodude
30 Mar 2017

Pull Request for Issue Make sure CLI files are only called from the command line, not a web interface

Summary of Changes

Adds the following check to the CLI files

// Make sure we're being called from the command line, not a web interface
if (PHP_SAPI !== 'cli')
{
	die('This is a command line only application.');
}

Testing Instructions

check that the CLI files still work and cannot be called from a web interface

Expected result

CLI file should still work
CLI files cannot be called from a web interface

Actual result

CLI file should still work
CLI files cannot be called from a web interface

Documentation Changes Required

none

avatar photodude photodude - open - 30 Mar 2017
avatar photodude photodude - change - 30 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2017
Category CLI
avatar photodude photodude - change - 30 Mar 2017
Labels Added: ?
avatar photodude
photodude - comment - 30 Mar 2017

Never mind... the JApplicationCli constructor has a check for it. So these changes are not needed.

avatar photodude photodude - change - 30 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-30 16:43:15
Closed_By photodude
avatar photodude photodude - close - 30 Mar 2017

Add a Comment

Login with GitHub to post a comment