[#15009] - [4.0]Fix com_banners issue
- Fixed in Code Base
- 31 Mar 2017
- Medium
- Build: 4.0-dev
- Easy Test
- # 15009
- Diff
- joomdonation:fix-banners
User tests: Successful: Unsuccessful:
Pull Request for Issue #14992 .
Summary of Changes
There was changes in component dispatcher implement makes banners component broken in the backend. This PR fixes it
Testing Instructions
- Install Joomla 4.0 nightly build
- Access to banners component, you will get errors
- Delete the file administrator/components/com_banners/dispatcher.php
- Apply patch, component works properly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
Yes. Because with the change recently, if a component has dispatcher.php file, it must be a namespaced component while our banners component is not namespaced yet
Ahh, got it.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.
Please delete the file administrator/components/com_banners/dispatcher.php manually before testing.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.
@joomdonation can you please update your Instructions so tester got proper Information?
@franz-wohlkoenig Done
I have tested this item
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful testes.
| Easy | No | ⇒ | Yes |
RTC after two successful testes.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-31 12:46:57 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
So what you're saying with this PR is the dispatcher concept as it was first merged is now broken/gone?