? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
30 Mar 2017

Pull Request for Issue #14992 .

Summary of Changes

There was changes in component dispatcher implement makes banners component broken in the backend. This PR fixes it

Testing Instructions

  1. Install Joomla 4.0 nightly build
  2. Access to banners component, you will get errors
  3. Delete the file administrator/components/com_banners/dispatcher.php
  4. Apply patch, component works properly.
avatar joomdonation joomdonation - open - 30 Mar 2017
avatar joomdonation joomdonation - change - 30 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2017
Category Administration com_banners
avatar mbabker
mbabker - comment - 30 Mar 2017

So what you're saying with this PR is the dispatcher concept as it was first merged is now broken/gone?

avatar joomdonation
joomdonation - comment - 30 Mar 2017

Yes. Because with the change recently, if a component has dispatcher.php file, it must be a namespaced component while our banners component is not namespaced yet

avatar mbabker
mbabker - comment - 30 Mar 2017

Ahh, got it.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Mar 2017

I have tested this item ? unsuccessfully on 1f6edac
bildschirmfoto 2017-03-30 um 18 40 17


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.
avatar joomdonation
joomdonation - comment - 30 Mar 2017

Please delete the file administrator/components/com_banners/dispatcher.php manually before testing.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Mar 2017

I have tested this item successfully on 1f6edac


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Mar 2017

@joomdonation can you please update your Instructions so tester got proper Information?

avatar joomdonation joomdonation - change - 30 Mar 2017
The description was changed
avatar joomdonation joomdonation - edited - 30 Mar 2017
avatar joomdonation
joomdonation - comment - 30 Mar 2017
avatar C-Lodder C-Lodder - test_item - 31 Mar 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 31 Mar 2017

I have tested this item successfully on 1f6edac

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15009.

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2017

RTC after two successful testes.

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2017

RTC after two successful testes.

avatar wilsonge wilsonge - change - 31 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-31 12:46:57
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 31 Mar 2017
avatar wilsonge wilsonge - merge - 31 Mar 2017

Add a Comment

Login with GitHub to post a comment