?
avatar PhilETaylor
PhilETaylor
29 Mar 2017

Steps to reproduce the issue

install joomla-cms/staging @ 4ba67b7
(Tested WITH and WITHOUT PR #14520 applies - makes no difference)

Add a single Editor custom field with name "editor" and otherwise default configuration

Create a new article, go to the editor on the fields tab,

Click Page Break

Click Insert Page Break

Expected result

That a page break is inserted into the customfields editor on the Fields tab.

Actual result

a whole webpage loads inside the modal, the modal stays open

screen shot 2017-03-29 at 16 32 32

System information (as much as possible)

https://gist.github.com/PhilETaylor/8db083650eb2e64aa59d02452103036c

Additional comments

MAY be related to
#14520
#14935

avatar PhilETaylor PhilETaylor - open - 29 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Mar 2017
avatar PhilETaylor PhilETaylor - change - 29 Mar 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 29 Mar 2017
avatar AlexRed
AlexRed - comment - 29 Mar 2017

I can confirm the problem


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14990.

avatar Bakual
Bakual - comment - 29 Mar 2017

#14520 does fix that one for me as well and it also only happens with TinyMCE (Codemirror is fine).
Make sure to have "Show Buttons" enabled in the editor fields plugin as that seems to be an issue with TinyMCE as well.

avatar PhilETaylor
PhilETaylor - comment - 29 Mar 2017

Why should I (a dump user) have to enable "Show buttons" to get a feature to work as expected?

This is a "out of the box" installation of Joomla. The features should work without me going and fudging my settings.

avatar PhilETaylor
PhilETaylor - comment - 29 Mar 2017

#14520 does fix that one for me as well and it also only happens with TinyMCE (Codemirror is fine). Make sure to have "Show Buttons" enabled in the editor fields plugin as that seems to be an issue with TinyMCE as well.

Simply stating that something works for you, under a totally different set of circumstances, doesnt mean that the reported issue is fixed or invalid... it means you did not test what was reported as an issue!

So, testing with 4ba67b7, with #14520 applied, an editor called editor, AND with setting "show buttons" to Yes (as opposed to 'use from plugin' default), a clean cache, I CAN STILL REPLICATE THE REPORTED ISSUE!

avatar PhilETaylor
PhilETaylor - comment - 29 Mar 2017

I can confirm that with CodeMirror enabled (instead of TinyMCE) this issue doesn't happen.

avatar Bakual
Bakual - comment - 29 Mar 2017

Why should I (a dump user) have to enable "Show buttons" to get a feature to work as expected?

I haven't said you should have to, I asked you to try if that helps so we can narrow down the issue.
I agree with you that the default value for this parameter should be "Yes", as I would expect the buttons to be enabled by default. But that's a completely different issue (and an easy one to sovle actually)

Simply stating that something works for you, under a totally different set of circumstances, doesnt mean that the reported issue is fixed or invalid... it means you did not test what was reported as an issue!

I can't follow you. I have tested exactly the same (actually also additional scenarios) and was able to reproduce the exact issue you mentioned and the PR fixed it for me. I'm now trying to find out why it didn't fix it for you as I can't reproduce the issue anymore after applying said PR.
While doing so I found an additional issues like the "Show Buttons" parameter not behaving correctly which I thought may be related to the difference between your setting and mine.

avatar PhilETaylor
PhilETaylor - comment - 30 Mar 2017

ok I have manually applied every change in #14520 to f45c0da and I can still replicate the reported issue

Im 100% convinced #14520 doesnt resolve this reported issue

avatar Bakual
Bakual - comment - 30 Mar 2017

Closing as we have a PR #14520

avatar Bakual Bakual - change - 30 Mar 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-03-30 18:28:14
Closed_By Bakual
avatar Bakual Bakual - close - 30 Mar 2017
avatar PhilETaylor PhilETaylor - comment - 30 Mar 2017

Add a Comment

Login with GitHub to post a comment